[reland]Enable distributed package on windows, Gloo backend supported only#45335
Closed
gunandrose4u wants to merge 67 commits intopytorch:masterfrom
Closed
[reland]Enable distributed package on windows, Gloo backend supported only#45335gunandrose4u wants to merge 67 commits intopytorch:masterfrom
gunandrose4u wants to merge 67 commits intopytorch:masterfrom
Conversation
Update my fork from Pytorch repo
Rebase from pytorch/pytorch master
Rebase latest code from master branch of PyTorch repo
Rebase code
Rebase to latest commits
Rebase to latest commits
Rebase to latest commit
Rebase to latest commits
Rebase to latest commits
Rebase to latest commits
Rebase latest commits
…pe is not supported yet on Windows
This reverts commit defd3ac.
gunandrose4u
requested review from
apaszke,
mrshenli,
pietern,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
facebook-github-bot
added
the
oncall: jit
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@mrshenli has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
gunandrose4u
changed the title
zou3519
added
the
triaged
mrshenli
approved these changes
Sep 25, 2020
Codecov Report
@@ Coverage Diff @@
## master #45335 +/- ##
==========================================
- Coverage 68.06% 68.04% -0.03%
==========================================
Files 393 393
Lines 50987 51024 +37
==========================================
+ Hits 34705 34719 +14
- Misses 16282 16305 +23
Continue to review full report at Codecov.
|
Contributor
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 29, 2021
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: Fixes test failure after pytorch#56598 Introduced by pytorch#45335. Pull Request resolved: pytorch#57000 Reviewed By: zou3519 Differential Revision: D28030360 Pulled By: seemethere fbshipit-source-id: 4871d51e6b80dceef8bf95c6c658441287575f63
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #{issue number}
This is resubmit for PR #42897 . Together with fix for Windows build issue introduced by PR #44344 .