Skip to content

.circleci: Remove optional_merge_target_branch #45281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seemethere wants to merge 1 commit into from
Closed

.circleci: Remove optional_merge_target_branch #45281

seemethere wants to merge 1 commit into from

Conversation

@seemethere
Copy link
Member

@seemethere seemethere commented Sep 24, 2020 •
edited
Loading

Stack from ghstack:

Might not be necessary anymore since XLA does not need to apply patches
on top of pytorch anymore.

Signed-off-by: Eli Uriegas [email protected]

Differential Revision: D23909883

@seemethere
.circleci: Remove optional_merge_target_branch
8c40c3c 
Might not be necessary anymore since XLA does not need to apply patches
on top of pytorch anymore.

Signed-off-by: Eli Uriegas <[email protected]>

[ghstack-poisoned]
seemethere added a commit that referenced this pull request Sep 24, 2020
@seemethere
.circleci: Remove optional_merge_target_branch
f7a5afe 
Might not be necessary anymore since XLA does not need to apply patches
on top of pytorch anymore.

Signed-off-by: Eli Uriegas <[email protected]>

ghstack-source-id: ad631aa
Pull Request resolved: #45281
@seemethere seemethere added module: ci Related to continuous integration module: xla Related to XLA support labels Sep 24, 2020
ailzhang
ailzhang reviewed Sep 24, 2020
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No the reason we want to rebase on top of pytorch master is we want to pick up any fixes in pytorch master if possible before running tests. Since we test against pytorch/xla master branch, it's possible that pytorch/xla master only works with pytorch master due to some coordinate landing issue.
Removing this will trigger a lot more CI failures on PRs unrelated to the change.

Also I think rebasing is also required for the BC testing jobs. cc: @houseroad who might have better context on it.

@dr-ci
Copy link

dr-ci bot commented Sep 24, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 8c40c3c (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 fixed upstream failure:

These were probably caused by upstream breakages that were already fixed.

Please rebase on the viable/strict branch (expand for instructions)

If your commit is newer than viable/strict, you can try basing on an older, stable commit:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase --onto FETCH_HEAD $(git merge-base origin/master HEAD)

If your commit is older than viable/strict:

git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

Check out the recency history of this "viable master" tracking branch.

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 2 times.

@seemethere seemethere closed this Oct 19, 2020
@facebook-github-bot facebook-github-bot deleted the gh/seemethere/28/head branch November 19, 2020 15:16
@seemethere seemethere mentioned this pull request Mar 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ailzhang ailzhang ailzhang left review comments

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

module: ci Related to continuous integration module: xla Related to XLA support

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@seemethere @ailzhang