[For ci-all tests] refactor intialize bucket views#44865
Closed
zhaojuanmao wants to merge 1 commit intomasterfrom
Closed
[For ci-all tests] refactor intialize bucket views#44865zhaojuanmao wants to merge 1 commit intomasterfrom
zhaojuanmao wants to merge 1 commit intomasterfrom
Conversation
Part of relanding PR #41954, this refactor is to seperate intialize_bucket_views and populate_bucket_views_out, as they are doing different things and called by different callsites as well Differential Revision: [D23583347](https://our.internmc.facebook.com/intern/diff/D23583347/) [ghstack-poisoned]
💊 CI failures summary and remediationsAs of commit 48126b8 (more details on the Dr. CI page):
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages:
|
Contributor
Author
|
test only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull from latest commit in #44330, push to the ci-all branch for triggering all ci-all tests in the PR.
Part of relanding PR #41954, this refactor is to seperate intialize_bucket_views and populate_bucket_views_out, as they are doing different things and called by different callsites as well