Enable complex blas for ROCm. #43744
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Skips some complex tests on ROCm (pytorch#42759)" This reverts commit 55b1706. Use new cuda_to_hip_mappings.py from pytorch#43004.
Codecov Report
@@ Coverage Diff @@
## master #43744 +/- ##
=======================================
Coverage 69.34% 69.34%
=======================================
Files 378 378
Lines 46680 46680
=======================================
+ Hits 32369 32370 +1
+ Misses 14311 14310 -1
Continue to review full report at Codecov.
|
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ngimel has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ngimel
approved these changes
Aug 28, 2020
Collaborator
ngimel
left a comment
ngimel
left a comment
There was a problem hiding this comment.
Looks good, waiting for ci.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Skips some complex tests on ROCm (#42759)". This reverts commit 55b1706.
Use new cuda_to_hip_mappings.py from #43004.
Fixes #42383 (comment)
CC @sunway513