Fix flaky NCCL error handling tests. #42149
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these tests were flaky since we could kill the process in some way without cleaning up the ProcessGroup. This resulted in issues where the FileStore didn't clean up appropriately resulting in other processes in the group to crash. Fixed this by explicitly deleting the process_group before we bring a process down forcibly. Differential Revision: [D22785042](https://our.internmc.facebook.com/intern/diff/D22785042/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Jul 28, 2020
Some of these tests were flaky since we could kill the process in some way without cleaning up the ProcessGroup. This resulted in issues where the FileStore didn't clean up appropriately resulting in other processes in the group to crash. Fixed this by explicitly deleting the process_group before we bring a process down forcibly. Differential Revision: [D22785042](https://our.internmc.facebook.com/intern/diff/D22785042/) ghstack-source-id: 108629057 Pull Request resolved: #42149
💊 CI failures summary and remediationsAs of commit 56802b7 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. |
mrshenli
approved these changes
Jul 28, 2020
Contributor
|
This pull request has been merged in 8deb4fe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Some of these tests were flaky since we could kill the process in some
way without cleaning up the ProcessGroup. This resulted in issues where the
FileStore didn't clean up appropriately resulting in other processes in the
group to crash.
Fixed this by explicitly deleting the process_group before we bring a process
down forcibly.
Differential Revision: D22785042
#Closes: #31924