Skip to content

Revert "Revert D22360735: .circleci: Build docker images as part of C… #40950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seemethere wants to merge 3 commits into from
Closed

Revert "Revert D22360735: .circleci: Build docker images as part of C… #40950

seemethere wants to merge 3 commits into from

Conversation

@seemethere
Copy link
Member

@seemethere seemethere commented Jul 2, 2020

…I workflow"

This reverts commit 3c6b8a6.

@seemethere seemethere requested a review from malfet July 2, 2020 23:45
@dr-ci
Copy link

dr-ci bot commented Jul 2, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit d28a106 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_linux_xenial_rocm3_5_1_py3_6_caffe2_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) <confirmed not flaky by 2 failures>

Aug 03 22:01:03 ../.local/lib/python3.6/site-packages/caffe2/python/operator_test/sequence_ops_test.py::TestSequenceOps::test_remove_data_blocks FAILED [ 94%] 
Aug 03 22:01:00 ../.local/lib/python3.6/site-packages/caffe2/python/operator_test/self_binning_histogram_test.py::TestSelfBinningHistogramLogarithmicFloat::test_histogram_very_small_range_for_stride_underflow PASSED [ 93%] 
Aug 03 22:01:01 ../.local/lib/python3.6/site-packages/caffe2/python/operator_test/selu_op_test.py::TestSelu::test_selu_1 PASSED [ 93%] 
Aug 03 22:01:01 ../.local/lib/python3.6/site-packages/caffe2/python/operator_test/selu_op_test.py::TestSelu::test_selu_2 PASSED [ 93%] 
Aug 03 22:01:02 ../.local/lib/python3.6/site-packages/caffe2/python/operator_test/selu_op_test.py::TestSelu::test_selu_3 PASSED [ 93%] 
Aug 03 22:01:02 ../.local/lib/python3.6/site-packages/caffe2/python/operator_test/selu_op_test.py::TestSelu::test_selu_inplace PASSED [ 93%] 
Aug 03 22:01:02 ../.local/lib/python3.6/site-packages/caffe2/python/operator_test/sequence_ops_test.py::TestSequenceOps::test_add_padding PASSED [ 93%] 
Aug 03 22:01:02 ../.local/lib/python3.6/site-packages/caffe2/python/operator_test/sequence_ops_test.py::TestSequenceOps::test_add_padding_no_length PASSED [ 93%] 
Aug 03 22:01:03 ../.local/lib/python3.6/site-packages/caffe2/python/operator_test/sequence_ops_test.py::TestSequenceOps::test_add_zero_padding PASSED [ 93%] 
Aug 03 22:01:03 ../.local/lib/python3.6/site-packages/caffe2/python/operator_test/sequence_ops_test.py::TestSequenceOps::test_find_duplicate_elements PASSED [ 93%] 
Aug 03 22:01:03 ../.local/lib/python3.6/site-packages/caffe2/python/operator_test/sequence_ops_test.py::TestSequenceOps::test_gather_padding PASSED [ 93%] 
Aug 03 22:01:03 ../.local/lib/python3.6/site-packages/caffe2/python/operator_test/sequence_ops_test.py::TestSequenceOps::test_remove_data_blocks FAILED [ 94%] 
Aug 03 22:01:03  
Aug 03 22:01:03 =================================== FAILURES =================================== 
Aug 03 22:01:03 ___________________ TestSequenceOps.test_remove_data_blocks ____________________ 
Aug 03 22:01:03  
Aug 03 22:01:03 self = <caffe2.python.operator_test.sequence_ops_test.TestSequenceOps testMethod=test_remove_data_blocks> 
Aug 03 22:01:03 args = (), kwargs = {} 
Aug 03 22:01:03  
Aug 03 22:01:03     def func(self, *args, **kwargs): 
Aug 03 22:01:03         self.should_serialize = True 
Aug 03 22:01:03 >       fixed_seed_func(self, *args, **kwargs)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 54 times.

@seemethere seemethere force-pushed the ci-all/seemethere/reland_docker_builder branch from 0a6f750 to 8640a39 Compare July 7, 2020 15:40
@seemethere seemethere added the module: ci Related to continuous integration label Jul 7, 2020
@seemethere seemethere mentioned this pull request Jul 8, 2020
Closed
@ezyang
Copy link
Contributor

ezyang commented Jul 19, 2020

What's the status on this? It would be really great to see this get in; for example would have made life in #38796 a lot easier.

@ezyang ezyang self-requested a review July 19, 2020 19:43
@seemethere seemethere force-pushed the ci-all/seemethere/reland_docker_builder branch 4 times, most recently from 2b2c3d0 to 6b5b061 Compare July 21, 2020 17:28
@ezyang
Copy link
Contributor

ezyang commented Jul 22, 2020

We're going to partially land this PR by way of #41846

cc @mattip

@seemethere
Copy link
Member Author

seemethere commented Jul 22, 2020

Am I doing something wrong here with tensorboard?

@ezyang
Copy link
Contributor

ezyang commented Jul 22, 2020

No, you need the fix that we rolled up in #38796

This is also a good reason why you should keep up to date with your GitHub notifications ;)

@seemethere seemethere force-pushed the ci-all/seemethere/reland_docker_builder branch from 6b5b061 to 0c11b9a Compare July 24, 2020 00:07
@seemethere seemethere mentioned this pull request Jul 24, 2020
Closed
seemethere and others added 2 commits August 3, 2020 14:56
@seemethere
Revert "Revert D22360735: .circleci: Build docker images as part of C…
7741148 
…I workflow"

This reverts commit 3c6b8a6.

Signed-off-by: Eli Uriegas <[email protected]>
@IvanKobzarev @seemethere
[docker][android] use aws instead of google repository
bcc449f 
ghstack-source-id: 079d031
Pull Request resolved: #42393
@seemethere seemethere force-pushed the ci-all/seemethere/reland_docker_builder branch from 0c11b9a to bcc449f Compare August 3, 2020 21:57
facebook-github-bot
facebook-github-bot reviewed Aug 3, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Aug 3, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@IvanKobzarev IvanKobzarev mentioned this pull request Aug 3, 2020
Closed
facebook-github-bot
facebook-github-bot reviewed Aug 3, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seemethere has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@seemethere
Copy link
Member Author

seemethere commented Aug 3, 2020

Currently blocked on #41680

@seemethere seemethere mentioned this pull request Aug 3, 2020
Closed
@seemethere
.circleci: Pin matplotlib to 3.2.2
d28a106 
Current tests are incompatible with matplotlib 3.3.0

Signed-off-by: Eli Uriegas <[email protected]>
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 4, 2020

@seemethere merged this pull request in 5939d8a.

@facebook-github-bot facebook-github-bot deleted the ci-all/seemethere/reland_docker_builder branch January 27, 2021 18:26
@seemethere seemethere mentioned this pull request May 11, 2021
Closed
71 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@malfet malfet malfet approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

Merged module: ci Related to continuous integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@seemethere @ezyang @facebook-github-bot @malfet @mruberry @IvanKobzarev