Skip to content

.circleci: Build docker images as part of CI workflow #40827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seemethere wants to merge 12 commits into from
Closed

.circleci: Build docker images as part of CI workflow #40827

seemethere wants to merge 12 commits into from

Conversation

@seemethere
Copy link
Member

@seemethere seemethere commented Jun 30, 2020 •
edited
Loading

Stack from ghstack:

Signed-off-by: Eli Uriegas [email protected]

Differential Revision: D22360735

@seemethere
.circleci: Build docker images as part of CI workflow
2f42536 
Signed-off-by: Eli Uriegas <[email protected]>

[ghstack-poisoned]
@dr-ci
Copy link

dr-ci bot commented Jun 30, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 1cf3769 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

1 failure confirmed as flaky and can be ignored:

  • docker-pytorch-linux-xenial-py3-clang5-android-ndk-r19c
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 35 times.

@seemethere seemethere marked this pull request as draft June 30, 2020 22:10
seemethere added a commit that referenced this pull request Jun 30, 2020
@seemethere
.circleci: Build docker images as part of CI workflow
d3103ba 
Signed-off-by: Eli Uriegas <[email protected]>

ghstack-source-id: 2357d23
Pull Request resolved: #40827

Signed-off-by: Eli Uriegas <[email protected]>
seemethere added a commit that referenced this pull request Jul 1, 2020
@seemethere
.circleci: Build docker images as part of CI workflow
3f7592e 
Signed-off-by: Eli Uriegas <[email protected]>

ghstack-source-id: a3564c4
Pull Request resolved: #40827

Signed-off-by: Eli Uriegas <[email protected]>
@seemethere
Copy link
Member Author

seemethere commented Jul 1, 2020

A note that I had to build the android image by hand since it was failing to build within CI since it appears as though android is blocking our requests.

@seemethere seemethere requested review from ezyang and malfet July 1, 2020 22:32
@seemethere seemethere added the module: ci Related to continuous integration label Jul 1, 2020
@seemethere seemethere marked this pull request as ready for review July 1, 2020 22:32
@seemethere seemethere linked an issue Jul 1, 2020 that may be closed by this pull request
[RFC] Improve the CI docker image builder workflow #37855
Closed
@seemethere seemethere mentioned this pull request Jul 2, 2020
Merged
@seemethere seemethere mentioned this pull request Jul 2, 2020
Closed
@VitalyFedyunin
Copy link
Contributor

VitalyFedyunin commented Jul 2, 2020

breaks https://circleci.com/gh/pytorch/pytorch/6106410?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link/console reverting

@mattip mattip mentioned this pull request Jul 22, 2020
Closed
@facebook-github-bot facebook-github-bot deleted the gh/seemethere/3/head branch August 2, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees

No one assigned

Labels

module: ci Related to continuous integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC] Improve the CI docker image builder workflow

4 participants

@seemethere @VitalyFedyunin @malfet