Skip to content

Python/C++ API Parity: Add impl and tests for ParameterDict #40654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arktrail wants to merge 1 commit into from
Closed

Python/C++ API Parity: Add impl and tests for ParameterDict #40654

arktrail wants to merge 1 commit into from

Conversation

@arktrail
Copy link
Contributor

@arktrail arktrail commented Jun 27, 2020

Summary: This diff contains the implementation of C++ api for ParameterDict from #25883, refer to #36904 and #28652

Test Plan: Add unit test in this diff

Reviewers:

Subscribers:

Tasks: #25883

Tags:

@arktrail arktrail mentioned this pull request Jun 27, 2020
Closed
@glaringlee glaringlee self-requested a review June 27, 2020 02:25
@glaringlee
Copy link
Contributor

glaringlee commented Jun 27, 2020

This is the same PR as #40014. Since #40014 is hard to rebase correctly, so we opened this with latest pytorch master.

facebook-github-bot
facebook-github-bot reviewed Jun 27, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glaringlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Jun 28, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glaringlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@glaringlee
Copy link
Contributor

glaringlee commented Jun 28, 2020

@yyn19951228 Thanks a lot for your help!. This PR is good to go.
There is currently an internal problem with facebook system, I can not land your code in at this point, will approve this as soon as I can land it.

@arktrail
Copy link
Contributor Author

arktrail commented Jun 28, 2020

Hi @glaringlee , thank you very much! And I understand that the system is not quite stable when I interned at Facebook months before. I am currently working on ParameterList, and will create a new PR when I finished that.

facebook-github-bot
facebook-github-bot reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glaringlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glaringlee has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

glaringlee
glaringlee approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@glaringlee glaringlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 29, 2020

@glaringlee merged this pull request in 4121d34.

@glaringlee glaringlee mentioned this pull request Oct 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

@glaringlee glaringlee glaringlee approved these changes

@ebetica ebetica Awaiting requested review from ebetica

@goldsborough goldsborough Awaiting requested review from goldsborough

@yf225 yf225 Awaiting requested review from yf225

Assignees

No one assigned

Labels

Merged open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@arktrail @glaringlee @facebook-github-bot @pytorchbot @mruberry