Fix illegal opcode bug in caffe2 #40584
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Also patch [this github issue](pytorch#33124) involving an illegal assembly instruction in 8x8-dq-aarch64-neon.S. Test Plan: Build binaries, copy to shaker, run executables. Also run all existing caffe tests. Differential Revision: D22240670 fbshipit-source-id: 55510f91a616f5e150a8cf5601438eea3493dc8f
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D22240670 |
Contributor
|
This pull request has been merged in 7676682. |
danieldk
added a commit
to danieldk/nixpkgs
that referenced
this pull request
Jun 30, 2020
aarch64-linux builds fail because of the use of opcodes in QNNPACK that the GNU assembpler does not support. This change cherry-picks an upstream patch that fixes this. See: pytorch/pytorch#33124 pytorch/pytorch#40584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Also patch this github issue
involving an illegal assembly instruction in 8x8-dq-aarch64-neon.S.
Test Plan:
Build binaries, copy to shaker, run executables. Also run all
existing caffe tests.
Differential Revision: D22240670