Skip to content

properly skip legacy tests regardless of the default executor #40381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Krovatkin wants to merge 1 commit into from
Closed

properly skip legacy tests regardless of the default executor #40381

Krovatkin wants to merge 1 commit into from

Conversation

@Krovatkin
Copy link
Contributor

@Krovatkin Krovatkin commented Jun 22, 2020

No description provided.

@dr-ci
Copy link

dr-ci bot commented Jun 22, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit f8e3368 (more details on the Dr. CI page):

  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-build-x86_32 (1/1)

Step: "pytorch android gradle build only x86_32 (for PR)" (full log | diagnosis details | 🔁 rerun)

Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] CMake Error: The following variables are used in this project, but they are set to NOTFOUND. 
Jun 22 18:35:40 18:35:39.862 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:99) 
Jun 22 18:35:40 18:35:39.862 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	... 31 more 
Jun 22 18:35:40 18:35:39.862 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Caused by: com.android.ide.common.process.ProcessException: Error configuring CMake server (/usr/local/bin).  
Jun 22 18:35:40 18:35:39.862 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Check for working CXX compiler: /opt/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ 
Jun 22 18:35:40 18:35:39.862 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Check for working CXX compiler: /opt/ndk/toolchains/llvm/prebuilt/linux-x86_64/bin/clang++ -- works 
Jun 22 18:35:40 18:35:39.862 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Detecting CXX compiler ABI info 
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Detecting CXX compiler ABI info - done 
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Detecting CXX compile features 
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Detecting CXX compile features - done 
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] ANDROID_STL:c++_shared 
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] CMake Error: The following variables are used in this project, but they are set to NOTFOUND. 
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Please set them or make sure they are set and tested correctly in the CMake files: 
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] PYTORCH_LIBRARY 
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]     linked by target "pytorch_testapp_jni" in directory /var/lib/jenkins/workspace/android/test_app/app 
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]  
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] Configuring incomplete, errors occurred! 
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] See also "/var/lib/jenkins/workspace/android/test_app/app/.externalNativeBuild/cmake/mbqLocalBaseRelease/x86/CMakeFiles/CMakeOutput.log". 
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter]  
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at com.android.build.gradle.tasks.CmakeServerExternalNativeJsonGenerator.executeProcessAndGetOutput(CmakeServerExternalNativeJsonGenerator.java:180) 
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at com.android.build.gradle.tasks.CmakeExternalNativeJsonGenerator.executeProcess(CmakeExternalNativeJsonGenerator.java:116) 
Jun 22 18:35:40 18:35:39.863 [ERROR] [org.gradle.internal.buildevents.BuildExceptionReporter] 	at com.android.build.gradle.tasks.ExternalNativeJsonGenerator.buildForOneConfiguration(ExternalNativeJsonGenerator.java:354)
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 1 time.

facebook-github-bot
facebook-github-bot reviewed Jun 22, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 26, 2020

@Krovatkin merged this pull request in 5036c94.

ZolotukhinM pushed a commit to ZolotukhinM/pytorch that referenced this pull request Jul 6, 2020
@Krovatkin
properly skip legacy tests regardless of the default executor (pytorc…
fa0a7df 
…h#40381)

Summary: Pull Request resolved: pytorch#40381

Differential Revision: D22173938

Pulled By: Krovatkin

fbshipit-source-id: 305fc4484977e828cc4cee6e053a1e1ab9f0d6c7
ZolotukhinM pushed a commit to ZolotukhinM/pytorch that referenced this pull request Jul 7, 2020
@Krovatkin
properly skip legacy tests regardless of the default executor (pytorc…
28ecd9f 
…h#40381)

Summary: Pull Request resolved: pytorch#40381

Differential Revision: D22173938

Pulled By: Krovatkin

fbshipit-source-id: 305fc4484977e828cc4cee6e053a1e1ab9f0d6c7
malfet pushed a commit that referenced this pull request Jul 7, 2020
@Krovatkin
[JIT] Switch executor from Simple to Legacy. (#41017)
11b70b0 
* properly skip legacy tests regardless of the default executor (#40381)

Summary: Pull Request resolved: #40381

Differential Revision: D22173938

Pulled By: Krovatkin

fbshipit-source-id: 305fc4484977e828cc4cee6e053a1e1ab9f0d6c7

* [JIT] Switch executor from Simple to Legacy.

This is done for 1.6 only in order to recover performance regressions
caused by the Legacy->Simple switch that was done in 1.5. On master we
still plan to use Simple executor and fix the performance issues in 1.7
without falling back to the Legacy executor.

Co-authored-by: Nikolay Korovaiko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

+1 more reviewer

@protonu protonu protonu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Krovatkin @facebook-github-bot @protonu @mruberry