[CUDA] Add addmv for complex dtypes #40238

anjali411 · 2020-06-18T20:24:46Z

No description provided.

dr-ci · 2020-06-18T20:49:49Z

💊 CI failures summary and remediations

As of commit bdbe749 (more details on the Dr. CI page):

5/5 failures introduced in this PR

🕵️ 5 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

pytorch_windows_vs2019_py36_cpu_test1 (1/5)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

RuntimeError: test_nn failed!

  File "C:\Jenkins\Miniconda3\lib\site-packages\scipy\_distributor_init.py", line 61, in <module> 
    WinDLL(os.path.abspath(filename)) 
  File "C:\Jenkins\Miniconda3\lib\ctypes\__init__.py", line 348, in __init__ 
    self._handle = _dlopen(self._name, mode) 
OSError: [WinError 126] The specified module could not be found 
Traceback (most recent call last): 
  File "run_test.py", line 721, in <module> 
    main() 
  File "run_test.py", line 714, in main 
    raise RuntimeError(message) 
RuntimeError: test_nn failed! 
 
(base) circleci@PACKER-5EE89590 C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1  
+ cleanup
+ retcode=1
+ set +x

pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-build-x86_32 (2/5)

Step: "pytorch android gradle build only x86_32 (for PR)" (full log | diagnosis details | 🔁 rerun)

Jun 22 14:51:08 ./.circleci/scripts/build_android_gradle.sh: line 73: /opt/gradle/gradle-6.5/bin/gradle: No such file or directory

Jun 22 14:51:08 ANDROID_NDK_HOME=/opt/ndk 
Jun 22 14:51:08 INSTALLED_DB= 
Jun 22 14:51:08 _=/usr/bin/env 
Jun 22 14:51:08 + export GRADLE_LOCAL_PROPERTIES=/var/lib/jenkins/workspace/android/local.properties 
Jun 22 14:51:08 + GRADLE_LOCAL_PROPERTIES=/var/lib/jenkins/workspace/android/local.properties 
Jun 22 14:51:08 + rm -f /var/lib/jenkins/workspace/android/local.properties 
Jun 22 14:51:08 + echo sdk.dir=/opt/android/sdk 
Jun 22 14:51:08 + echo ndk.dir=/opt/ndk 
Jun 22 14:51:08 + echo cmake.dir=/usr/local 
Jun 22 14:51:08 + /opt/gradle/gradle-6.5/bin/gradle -p android assembleRelease --debug --stacktrace -PABI_FILTERS=x86 --offline 
Jun 22 14:51:08 ./.circleci/scripts/build_android_gradle.sh: line 73: /opt/gradle/gradle-6.5/bin/gradle: No such file or directory

pytorch_windows_vs2019_py36_cuda10.1_on_cpu_test1 (3/5)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

RuntimeError: test_nn failed!

  File "C:\Jenkins\Miniconda3\lib\site-packages\scipy\_distributor_init.py", line 61, in <module> 
    WinDLL(os.path.abspath(filename)) 
  File "C:\Jenkins\Miniconda3\lib\ctypes\__init__.py", line 348, in __init__ 
    self._handle = _dlopen(self._name, mode) 
OSError: [WinError 126] The specified module could not be found 
Traceback (most recent call last): 
  File "run_test.py", line 721, in <module> 
    main() 
  File "run_test.py", line 714, in main 
    raise RuntimeError(message) 
RuntimeError: test_nn failed! 
 
(base) circleci@PACKER-5ECD3249 C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1  
+ cleanup
+ retcode=1
+ set +x

pytorch_windows_vs2019_py36_cuda10.1_test1 (4/5)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

RuntimeError: test_nn failed!

  File "C:\Jenkins\Miniconda3\lib\site-packages\scipy\_distributor_init.py", line 61, in <module> 
    WinDLL(os.path.abspath(filename)) 
  File "C:\Jenkins\Miniconda3\lib\ctypes\__init__.py", line 348, in __init__ 
    self._handle = _dlopen(self._name, mode) 
OSError: [WinError 126] The specified module could not be found 
Traceback (most recent call last): 
  File "run_test.py", line 721, in <module> 
    main() 
  File "run_test.py", line 714, in main 
    raise RuntimeError(message) 
RuntimeError: test_nn failed! 
 
(base) circleci@PACKER-5EE89583 C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1  
+ cleanup
+ retcode=1
+ set +x

pytorch_windows_vs2019_py36_cuda10.1_test2 (5/5)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

RuntimeError: test_cuda failed!

  File "C:\Jenkins\Miniconda3\lib\site-packages\scipy\_distributor_init.py", line 61, in <module> 
    WinDLL(os.path.abspath(filename)) 
  File "C:\Jenkins\Miniconda3\lib\ctypes\__init__.py", line 348, in __init__ 
    self._handle = _dlopen(self._name, mode) 
OSError: [WinError 126] The specified module could not be found 
Traceback (most recent call last): 
  File "run_test.py", line 721, in <module> 
    main() 
  File "run_test.py", line 714, in main 
    raise RuntimeError(message) 
RuntimeError: test_cuda failed! 
 
(base) circleci@PACKER-5ECD3242 C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1  
+ cleanup
+ retcode=1
+ set +x

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 37 times.

aten/src/ATen/cuda/CUDABlas.h

zasdfgbnm · 2020-06-18T20:52:22Z

I remember I saw this PR before, was that one reverted due to windows failure?

anjali411 · 2020-06-18T21:21:46Z

I remember I saw this PR before, was that one reverted due to windows failure?

yeah

aten/src/ATen/native/cuda/Blas.cu

zasdfgbnm · 2020-06-19T21:36:05Z

aten/src/ATen/cuda/CUDABlas.cpp


+template <>
+void gemv<c10::complex<double>>(CUDABLAS_GEMV_ARGTYPES(c10::complex<double>)) {
+  cublasHandle_t handle = at::cuda::getCurrentCUDABlasHandle();


I believe you need to ifdef the function body for ROCm as well?

zasdfgbnm

LGTM, given that ROCm CI is not failing

facebook-github-bot

@anjali411 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2020-06-22T17:57:56Z

@anjali411 merged this pull request in c72ab19.

anjali411 requested a review from zasdfgbnm June 18, 2020 20:24

anjali411 added the module: complex Related to complex number support in PyTorch label Jun 18, 2020

zasdfgbnm reviewed Jun 18, 2020

View reviewed changes

aten/src/ATen/cuda/CUDABlas.h Outdated Show resolved Hide resolved

zasdfgbnm reviewed Jun 18, 2020

View reviewed changes

aten/src/ATen/native/cuda/Blas.cu Outdated Show resolved Hide resolved

anjali411 requested review from apaszke, mrshenli, pietern, pritamdamania87 and zhaojuanmao as code owners June 18, 2020 23:51

anjali411 and others added 4 commits June 18, 2020 16:56

Add addmv for complex dtypes

6c45447

minor

798341e

minor

7d79fe5

Add addmv for complex dtypes

067a484

anjali411 force-pushed the addmv_complex branch from 631a794 to c2e0b16 Compare June 18, 2020 23:59

minor

645dcc1

anjali411 force-pushed the addmv_complex branch from c2e0b16 to 645dcc1 Compare June 19, 2020 00:01

anjali411 added 3 commits June 19, 2020 05:34

minor

24f4ef7

handle beta for complex

e6e29d7

skip rocm

40792e4

zasdfgbnm reviewed Jun 19, 2020

View reviewed changes

zasdfgbnm approved these changes Jun 19, 2020

View reviewed changes

disabled complex addmv for rocm

bdbe749

facebook-github-bot reviewed Jun 22, 2020

View reviewed changes

anjali411 requested a review from mruberry June 22, 2020 17:19

facebook-github-bot closed this in c72ab19 Jun 22, 2020

facebook-github-bot added the merged label Jun 22, 2020

facebook-github-bot deleted the addmv_complex branch July 13, 2020 17:53

anjali411 mentioned this pull request Jul 13, 2020

Complex Numbers Support #33152

Closed

anjali411 changed the title ~~Add addmv for complex dtypes~~ [CUDA] Add addmv for complex dtypes Jul 22, 2020

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CUDA] Add addmv for complex dtypes #40238

[CUDA] Add addmv for complex dtypes #40238

Uh oh!

anjali411 commented Jun 18, 2020

Uh oh!

dr-ci bot commented Jun 18, 2020 •

edited

Loading

Uh oh!

Uh oh!

zasdfgbnm commented Jun 18, 2020

Uh oh!

anjali411 commented Jun 18, 2020

Uh oh!

Uh oh!

zasdfgbnm Jun 19, 2020

Uh oh!

zasdfgbnm left a comment

Uh oh!

facebook-github-bot left a comment

Uh oh!

facebook-github-bot commented Jun 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[CUDA] Add addmv for complex dtypes #40238

[CUDA] Add addmv for complex dtypes #40238

Uh oh!

Conversation

anjali411 commented Jun 18, 2020

Uh oh!

dr-ci bot commented Jun 18, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

🕵️ 5 new failures recognized by patterns

pytorch_windows_vs2019_py36_cpu_test1 (1/5)

pytorch-linux-xenial-py3-clang5-android-ndk-r19c-gradle-build-x86_32 (2/5)

pytorch_windows_vs2019_py36_cuda10.1_on_cpu_test1 (3/5)

pytorch_windows_vs2019_py36_cuda10.1_test1 (4/5)

pytorch_windows_vs2019_py36_cuda10.1_test2 (5/5)

Uh oh!

Uh oh!

zasdfgbnm commented Jun 18, 2020

Uh oh!

anjali411 commented Jun 18, 2020

Uh oh!

Uh oh!

zasdfgbnm Jun 19, 2020

Choose a reason for hiding this comment

Uh oh!

zasdfgbnm left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Jun 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dr-ci bot commented Jun 18, 2020 •

edited

Loading