.circleci: Add docker builds based on rev-parse #40194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the scaffolding for doing docker builds based off git rev-parse tags to detect changes. Basically allows us to do our previous builds while also prepping for the new builds by just retagging our current builds as the new ones and telling the garbage collector not to reap them. Should also skip out on redundant builds if the image already exists thus saving us some compute time on docker builds. Also adds the commands to load the calculated DOCKER_TAG from a shared workspace file. Signed-off-by: Eli Uriegas <[email protected]> [ghstack-poisoned]
seemethere
added a commit
that referenced
this pull request
Jun 17, 2020
Adds the scaffolding for doing docker builds based off git rev-parse tags to detect changes. Basically allows us to do our previous builds while also prepping for the new builds by just retagging our current builds as the new ones and telling the garbage collector not to reap them. Should also skip out on redundant builds if the image already exists thus saving us some compute time on docker builds. Also adds the commands to load the calculated DOCKER_TAG from a shared workspace file. Signed-off-by: Eli Uriegas <[email protected]> ghstack-source-id: a0bd93d Pull Request resolved: #40194
malfet
approved these changes
Jun 18, 2020
Contributor
|
@seemethere merged this pull request in 83d7718. |
xwang233
pushed a commit
to xwang233/pytorch
that referenced
this pull request
Jun 20, 2020
Summary: Pull Request resolved: pytorch#40194 Adds the scaffolding for doing docker builds based off git rev-parse tags to detect changes. Basically allows us to do our previous builds while also prepping for the new builds by just retagging our current builds as the new ones and telling the garbage collector not to reap them. Should also skip out on redundant builds if the image already exists thus saving us some compute time on docker builds. Also adds the commands to load the calculated DOCKER_TAG from a shared workspace file. Signed-off-by: Eli Uriegas <[email protected]> Test Plan: Imported from OSS Differential Revision: D22120651 Pulled By: seemethere fbshipit-source-id: c74f10816d63f440a9e0cdd00d6fa1a25eb7a2c1
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Adds the scaffolding for doing docker builds based off git rev-parse
tags to detect changes.
Basically allows us to do our previous builds while also prepping for
the new builds by just retagging our current builds as the new ones and
telling the garbage collector not to reap them.
Should also skip out on redundant builds if the image already exists
thus saving us some compute time on docker builds.
Also adds the commands to load the calculated DOCKER_TAG from a shared
workspace file.
Signed-off-by: Eli Uriegas [email protected]
Differential Revision: D22120651