Port /test/cpp_extensions/rng_extension.cpp to new operator registration API #39459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: Make it an error to def() an operator multiple times Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
changjishi
pushed a commit
that referenced
this pull request
Jun 3, 2020
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: Make it an error to def() an operator multiple times Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 38939c8 Pull Request resolved: #39459
💊 CI failures summary and remediationsAs of commit ecc8263 (more details on the Dr. CI page): ✅ None of the CI failures appear to be your fault 💚
🚧 1 fixed upstream failure:These were probably caused by upstream breakages that were already fixed.
Please rebase on the
|
Contributor
|
I see relevant failures in CI? :) |
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: #37010 Tags: [ghstack-poisoned]
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: #37010 Tags: [ghstack-poisoned]
changjishi
pushed a commit
that referenced
this pull request
Jun 8, 2020
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: Make it an error to def() an operator multiple times Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 515ef5a Pull Request resolved: #39459
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: #37010 Tags: [ghstack-poisoned]
Contributor
|
You've accidentally updated submodules in the diff; take a look at https://stackoverflow.com/questions/7718780/how-to-undo-git-submodule-update for how to fix it |
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: #37010 Tags: [ghstack-poisoned]
changjishi
pushed a commit
that referenced
this pull request
Jun 9, 2020
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: Make it an error to def() an operator multiple times Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 076a0c6 Pull Request resolved: #39459
Contributor
Author
Right, resolved. |
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: #37010 Tags: [ghstack-poisoned]
changjishi
pushed a commit
that referenced
this pull request
Jun 11, 2020
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: Make it an error to def() an operator multiple times Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 784b153 Pull Request resolved: #39459
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: #37010 Tags: [ghstack-poisoned]
changjishi
pushed a commit
that referenced
this pull request
Jun 11, 2020
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: Make it an error to def() an operator multiple times Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: ca1c898 Pull Request resolved: #39459
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: #37010 Tags: [ghstack-poisoned]
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: #37010 Tags: [ghstack-poisoned]
changjishi
pushed a commit
that referenced
this pull request
Jun 24, 2020
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: Make it an error to def() an operator multiple times Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 433b76a Pull Request resolved: #39459
Contributor
|
The binary files are committed by accident and need to be removed |
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: #37010 Tags: [ghstack-poisoned]
changjishi
pushed a commit
that referenced
this pull request
Jun 26, 2020
Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: Make it an error to def() an operator multiple times Summary: Previously, if an operator is defined multiple times, it will be merged anyways. This code changes the behavior to spitting error if an operator is defined more than once. Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 9e9d686 Pull Request resolved: #39459
changjishi
changed the title
ezyang
approved these changes
Jun 26, 2020
Contributor
|
This pull request has been merged in 47c72be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Update to this PR: this code isn't going to fully solve #37010. The changes required for 37010 is more than this PR initially planned. Instead, this PR switches op registration of rng related tests to use the new API (similar to what was done in #36925)
Test Plan:
Reviewers:
Subscribers:
Tasks: #37010
Tags:
Differential Revision: D22264889