Skip to content

[CUDA] addmv for complex tensors #37940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anjali411 wants to merge 11 commits into from
Closed

[CUDA] addmv for complex tensors #37940

anjali411 wants to merge 11 commits into from

Conversation

@anjali411
Copy link
Contributor

@anjali411 anjali411 commented May 6, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D21449462

@anjali411 anjali411 mentioned this pull request May 6, 2020
Closed
@anjali411 anjali411 requested a review from zasdfgbnm May 6, 2020 17:26
@dr-ci
Copy link

dr-ci bot commented May 6, 2020 •
edited
Loading

💊 CI failures summary and remediations

As of commit 698d4ba (more details on the Dr. CI page):

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_windows_vs2019_py36_cuda10.1_test2 (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

AssertionError: Not within tolerance rtol=1.3e-06 atol=1e-05 at input[0] (33.0 vs. 11.0) and 1 other locations (100.00%) 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_utils.py", line 979, in assertEqual 
    assertTensorsEqual(x, y) 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_utils.py", line 937, in assertTensorsEqual 
    atol=atol, rtol=rtol, message=message) 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_utils.py", line 979, in assertEqual 
    assertTensorsEqual(x, y) 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\_internal\common_utils.py", line 941, in assertTensorsEqual 
    torch.testing.assert_allclose(a, b, atol=atol, rtol=rtol, equal_nan=True, msg=message) 
  File "C:\Users\circleci\project\build\win_tmp\build\torch\testing\__init__.py", line 60, in assert_allclose 
    raise AssertionError(msg) 
AssertionError: Not within tolerance rtol=1.3e-06 atol=1e-05 at input[0] (33.0 vs. 11.0) and 1 other locations (100.00%) 
 
---------------------------------------------------------------------- 
Ran 5180 tests in 346.196s 
 
FAILED (failures=2, skipped=209) 
 
Generating XML reports... 
Generated XML report: test-reports\python-unittest\TEST-TestDevicePrecisionCUDA-20200512035957.xml 
Generated XML report: test-reports\python-unittest\TEST-TestTensorDeviceOpsCPU-20200512035957.xml 
Generated XML report: test-reports\python-unittest\TEST-TestTensorDeviceOpsCUDA-20200512035957.xml

❄️ 1 failure tentatively classified as flaky

but reruns have not yet been triggered to confirm:

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (1/1)

Step: "Run tests" (full log | diagnosis details | 🔁 rerun) ❄️

May 12 03:49:56 ConnectionResetError: [Errno 104] Connection reset by peer 
May 12 03:49:56   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 455, in accept 
May 12 03:49:56     deliver_challenge(c, self._authkey) 
May 12 03:49:56   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 722, in deliver_challenge 
May 12 03:49:56     response = connection.recv_bytes(256)        # reject large message 
May 12 03:49:56   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 216, in recv_bytes 
May 12 03:49:56     buf = self._recv_bytes(maxlength) 
May 12 03:49:56   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 407, in _recv_bytes 
May 12 03:49:56     buf = self._recv(4) 
May 12 03:49:56   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 379, in _recv 
May 12 03:49:56     chunk = read(handle, remaining) 
May 12 03:49:56 ConnectionResetError: [Errno 104] Connection reset by peer 
May 12 03:49:56 /opt/conda/lib/python3.6/multiprocessing/semaphore_tracker.py:143: UserWarning: semaphore_tracker: There appear to be 14 leaked semaphores to clean up at shutdown 
May 12 03:49:56   len(cache)) 
May 12 03:49:58 Process ErrorTrackingProcess-126: 
May 12 03:49:58 Traceback (most recent call last): 
May 12 03:49:58   File "/opt/conda/lib/python3.6/multiprocessing/process.py", line 258, in _bootstrap 
May 12 03:49:58     self.run() 
May 12 03:49:58   File "/var/lib/jenkins/workspace/test/test_dataloader.py", line 362, in run 
May 12 03:49:58     super(ErrorTrackingProcess, self).run() 
May 12 03:49:58   File "/opt/conda/lib/python3.6/multiprocessing/process.py", line 93, in run 
May 12 03:49:58     self._target(*self._args, **self._kwargs)

ci.pytorch.org: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 52 times.

zasdfgbnm
zasdfgbnm reviewed May 6, 2020
View reviewed changes
Copy link
Collaborator

@zasdfgbnm zasdfgbnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add reinterpret castable test to cuComplex and cuComplexDouble in https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/test/cuda_complex_test.cu#L36

@anjali411
Copy link
Contributor Author

anjali411 commented May 6, 2020

Could you also add reinterpret castable test to cuComplex and cuComplexDouble in https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/test/cuda_complex_test.cu#L36

yeah good idea! will do

anjali411 added a commit that referenced this pull request May 7, 2020
@anjali411
[CUDA] addmv for complex tensors
36db2fe 
ghstack-source-id: 784382f
Pull Request resolved: #37940
anjali411 added a commit that referenced this pull request May 7, 2020
@anjali411
[CUDA] addmv for complex tensors
2e2f796 
ghstack-source-id: 6c11644
Pull Request resolved: #37940
anjali411 added a commit that referenced this pull request May 7, 2020
@anjali411
[CUDA] addmv for complex tensors
e7bf15f 
ghstack-source-id: e253270
Pull Request resolved: #37940
anjali411 added a commit that referenced this pull request May 11, 2020
@anjali411
[CUDA] addmv for complex tensors
22a7af9 
ghstack-source-id: 42d4fc6
Pull Request resolved: #37940
anjali411 added a commit that referenced this pull request May 12, 2020
@anjali411
[CUDA] addmv for complex tensors
0170f73 
ghstack-source-id: 1ac56af
Pull Request resolved: #37940
zasdfgbnm
zasdfgbnm reviewed May 12, 2020
View reviewed changes
aten/src/ATen/Dispatch.h Outdated

#define AT_DISPATCH_ALL_TYPES_AND_COMPLEX_AND3( \
SCALARTYPE1, SCALARTYPE2, SCALARTYPE3, TYPE, NAME, ...) \
[&] { \
Copy link
Collaborator

@zasdfgbnm zasdfgbnm May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is changed? I guess there is something wrong with the merge conflict. AT_DISPATCH_ALL_TYPES_AND_C10_COMPLEX_AND3 has been removed and AT_DISPATCH_ALL_TYPES_AND_COMPLEX_AND3 now uses c10::complex

Copy link
Contributor Author

@anjali411 anjali411 May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah fixed it

anjali411 added a commit that referenced this pull request May 12, 2020
@anjali411
[CUDA] addmv for complex tensors
45e4269 
ghstack-source-id: f6da9d5
Pull Request resolved: #37940
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 12, 2020

@anjali411 merged this pull request in 0d977e9.

@zasdfgbnm zasdfgbnm deleted the gh/anjali411/14/head branch May 12, 2020 06:25
@anjali411 anjali411 removed the merged label May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zasdfgbnm zasdfgbnm zasdfgbnm approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anjali411 @facebook-github-bot @zasdfgbnm @mruberry