Skip to content

[CPU] addmv for complex tensors #37924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anjali411 wants to merge 4 commits into from
Closed

[CPU] addmv for complex tensors #37924

anjali411 wants to merge 4 commits into from

Conversation

@anjali411
Copy link
Contributor

@anjali411 anjali411 commented May 6, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D21429384

anjali411 added a commit that referenced this pull request May 6, 2020
@anjali411
[CPU] addmv for complex tensors
9de2a17 
ghstack-source-id: 55e6c50
Pull Request resolved: #37924
@anjali411 anjali411 requested a review from zasdfgbnm May 6, 2020 14:42
@dr-ci
Copy link

dr-ci bot commented May 6, 2020 •
edited
Loading

💊 Build failures summary and remediations

As of commit d384933 (more details on the Dr. CI page):

  • 1/1 failures possibly* introduced in this PR
    • 1/1 non-CircleCI failure(s)

Extra GitHub checks: 1 failed

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 8 times.

anjali411 added a commit that referenced this pull request May 6, 2020
@anjali411
[CPU] addmv for complex tensors
5b81002 
ghstack-source-id: 249f373
Pull Request resolved: #37924
@anjali411 anjali411 mentioned this pull request May 6, 2020
Closed
zasdfgbnm
zasdfgbnm approved these changes May 6, 2020
View reviewed changes
Copy link
Collaborator

@zasdfgbnm zasdfgbnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realize that CPU BLAS also supports complex. We might want to support it in the future.

@anjali411
Copy link
Contributor Author

anjali411 commented May 6, 2020 •
edited
Loading

Just realize that CPU BLAS also supports complex. We might want to support it in the future.

sorry I don't follow. support what in the future?

@zasdfgbnm
Copy link
Collaborator

zasdfgbnm commented May 6, 2020 •
edited
Loading

@anjali411 This PR does not automatically make gemv to use BLAS cgemv and zgemv for complex when available, but I feel it is good enough to get this landed for now, but we should make gemv to use BLAS in the future.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented May 6, 2020

@anjali411 merged this pull request in 4c4816a.

@anjali411
Copy link
Contributor Author

anjali411 commented May 6, 2020

cgemv

oh I see yeah that makes sense. I'll create a follow-up PR for that

xuezhou1998 pushed a commit to xuezhou1998/new_pytorch that referenced this pull request May 9, 2020
@anjali411
[CPU] addmv for complex tensors
117ffd3 
ghstack-source-id: aa60852
Pull Request resolved: pytorch/pytorch#37924
@anjali411 anjali411 mentioned this pull request Jul 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zasdfgbnm zasdfgbnm zasdfgbnm approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@anjali411 @zasdfgbnm @facebook-github-bot @mruberry