-
Notifications
You must be signed in to change notification settings - Fork 26.3k
C++ Parameterlist #36904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ Parameterlist #36904
Conversation
|
cc. @yf225 @d-ferrara |
💊 Build failures summary and remediationsAs of commit 70c5a82 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following build failures do not appear to be due to upstream breakages:
|
|
@haoyang77 please fix lint error first, replace tab with space. To run c++ api test. You can build the entire pytorch, then the test executable will be build/bin/test_api, executing this will run all the test drivers in /pytorch/test/cpp/api/. To run a specific one, you can do something like: |
glaringlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haoyang77 I commented above, please let me know if you need anything.
|
Hi @haoyang77! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Hi. This is what I have for C++ parameterlist.
Although I have tested it by creating a pytorch C++ project, I would like to test it properly by using the GoodleTest framework. However I have problem to build the cpp tests. Do I just run
python test/run_test.pyto build the tests? Is there a way for me just to build the tests in test/cpp?This is my first time contributing to open source project so many of my codes might need to be improved or not meet the requirement. Let me know if there is anything need to be changed.
Related issue: #25883