Add channels-last support to bundled_inputs #36764
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This allows bundling inputs that are large uniform buffers in channels-last memory format. Test Plan: Unit test. [ghstack-poisoned]
💊 Build failures summary and remediationsAs of commit 05af798 (more details on the Dr. CI page):
🕵️ 2 new failures recognized by patternsThe following build failures do not appear to be due to upstream breakages:
|
Summary: This allows bundling inputs that are large uniform buffers in channels-last memory format. Test Plan: Unit test. Differential Revision: [D21142660](https://our.internmc.facebook.com/intern/diff/D21142660) [ghstack-poisoned]
| self.assertEqual(inflated[4][0].shape, (1 << 16,)) | ||
| self.assertAlmostEqual(inflated[4][0].mean().item(), 0, delta=0.025) | ||
| self.assertAlmostEqual(inflated[4][0].std().item(), 1, delta=0.02) | ||
| self.assertEqual(inflated[5][0].shape, (1 << 16,)) |
Contributor
There was a problem hiding this comment.
Super nit: use -1 or len(samples)
VitalyFedyunin
approved these changes
Apr 29, 2020
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
This allows bundling inputs that are large uniform buffers in
channels-last memory format.
Test Plan:
Unit test.
Differential Revision: D21142660