Enable tensorexpr cpp tests in CI. try #2 #35454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

Krovatkin wants to merge 7 commits into pytorch:master from Krovatkin:krovatkin/enable_cpp_tests

Contributor

Krovatkin commented Mar 26, 2020

No description provided.

Krovatkin requested a review from ZolotukhinM

March 26, 2020 04:34

Krovatkin requested a review from apaszke as a code owner

March 26, 2020 04:34

facebook-github-bot added the oncall: jit label

dr-ci bot commented Mar 26, 2020 •

edited

Loading

💊 CircleCI build failures summary and remediations

As of commit bed40f3 (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 24 times.

ZolotukhinM approved these changes

View reviewed changes

ZolotukhinM left a comment

Re-approving.

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Krovatkin force-pushed the krovatkin/enable_cpp_tests branch from 763eb8e to f8abbe4 Compare

March 26, 2020 18:45

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Krovatkin added 7 commits

March 26, 2020 17:07


          Revert "Revert D20630760: [pytorch][PR] Enable NNC tests vol. i. add …

09fe3a1

…test_tensorexpr.py tests [WIP]"

This reverts commit aa01a95.


          add test cpp files to build_variables.bzl

2d9a2a3


          Fix comp errors

d136764


          fix more failures

55b21fc


          use ignore directive

ccbf55d


          fix attr

f53ca01


          fix more asan failures

bed40f3

Krovatkin force-pushed the krovatkin/enable_cpp_tests branch from cabc7d0 to bed40f3 Compare

March 27, 2020 00:08

facebook-github-bot reviewed

View reviewed changes

Contributor

facebook-github-bot left a comment

@Krovatkin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot closed this in

9e22d15

facebook-github-bot added the merged label

Contributor

facebook-github-bot commented Mar 28, 2020

@Krovatkin merged this pull request in 9e22d15.

mruberry added the Merged label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged oncall: jit