Fix thread_local initializtion in C10 WarningHandler. #34822
Conversation
💊 CircleCI build failures summary and remediationsAs of commit 6ac55bc (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 21 times. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@HapeMask has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
smessmer
left a comment
smessmer
left a comment
There was a problem hiding this comment.
Fix looks good but I think we should factor this out into a singleton-like function, i.e. make warning_handler_ private on something and have a get_warning_handler() function that returns it and initializes it before if necessary. This way, we can make sure we never access it while uninitialized.
HapeMask
force-pushed
the
fix_warning_thread_local
branch
from
c3567d1 to
32f6d8b
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@HapeMask has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: The Windows + MSVC-specific bug discussed here: pytorch#19394 and fixed here: pytorch#22405 still appears in C10's warning handler class. This results in a crash if a user attempts to run code which would print a warning when that code is running inside a thread created by a DLL. This PR applies a similar fix to that of pytorch#22405. Pull Request resolved: pytorch#34822 Test Plan: * Tested locally by running CodecverseWorkbench Unity app with patched build. * CI Differential Revision: D20627971 Pulled By: HapeMask fbshipit-source-id: 64dfca531ed7eebbe9e0ecac3d3d4d025c683883
Summary: The Windows + MSVC-specific bug discussed here: #19394 and fixed here: #22405 still appears in C10's warning handler class. This results in a crash if a user attempts to run code which would print a warning when that code is running inside a thread created by a DLL. This PR applies a similar fix to that of #22405. Pull Request resolved: #34822 Test Plan: * Tested locally by running CodecverseWorkbench Unity app with patched build. * CI Differential Revision: D20627971 Pulled By: HapeMask fbshipit-source-id: 64dfca531ed7eebbe9e0ecac3d3d4d025c683883
5 participants
The Windows + MSVC-specific bug discussed here: #19394 and fixed here: #22405 still appears in C10's warning handler class. This results in a crash if a user attempts to run code which would print a warning when that code is running inside a thread created by a DLL. This PR applies a similar fix to that of #22405.