Skip to content

Conversation

@yf225
Copy link
Contributor

@yf225 yf225 commented Mar 6, 2020

This PR adds RNNCell / LSTMCell / GRUCell layers to the C++ frontend, with implementations exactly matching the Python API equivalent.

@dr-ci
Copy link

dr-ci bot commented Mar 6, 2020

💊 CircleCI build failures summary and remediations

As of commit 0b680c7 (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 1/1 broken upstream at merge base e95657b since Mar 12

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch origin viable/strict
    git rebase --onto viable/strict $(git merge-base origin/master HEAD)
    

    If your commit is older than viable/strict:

    git fetch origin viable/strict
    git rebase viable/strict
    

    Check out the recency history of this "viable master" tracking branch.


🚧 1 upstream failure:

These were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 51 times.

@yf225 yf225 force-pushed the cpp_rnn_cell_layers branch 2 times, most recently from 1b947a9 to 0f86011 Compare March 6, 2020 23:36
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yf225 yf225 force-pushed the cpp_rnn_cell_layers branch 16 times, most recently from a8daa79 to 0dd231b Compare March 7, 2020 20:05
@yf225 yf225 force-pushed the cpp_rnn_cell_layers branch from 0dd231b to 94f7146 Compare March 7, 2020 20:08
@yf225 yf225 changed the title [WIP] [C++ API] RNNCell / LSTMCell / GRUCell layers [C++ API] RNNCell / LSTMCell / GRUCell layers Mar 7, 2020
@yf225 yf225 requested a review from pbelevich March 7, 2020 20:08
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yf225 yf225 added the module: cpp Related to C++ API label Mar 9, 2020
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@yf225 merged this pull request in d041d07.

@yf225 yf225 reopened this Mar 14, 2020
@yf225 yf225 added merged and removed merged labels Mar 14, 2020
@yf225 yf225 closed this Mar 14, 2020
@facebook-github-bot facebook-github-bot deleted the cpp_rnn_cell_layers branch July 13, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: cpp Related to C++ API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants