[resubmit] try to infer rref type from python #33992
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
jamesr66a
approved these changes
Feb 29, 2020
Contributor
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: Pull Request resolved: pytorch#33992 resubmit of pytorch#33369 with tweaks on when the rref type being created to ensure ivalue->type() hold the correct RRef type inside of inner element type. Test Plan: Imported from OSS Differential Revision: D20175043 Pulled By: wanchaol fbshipit-source-id: a08b178e989c995632374e6c868d23c5a85526ae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
resubmit of #33369 (reverted in #33920), with tweak on when the rref type being created to ensure ivalue->type() hold the correct RRef type inside of inner element type.
Differential Revision: D20175043