[JIT] add support for torch.cdist #33737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Feb 25, 2020
[ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
💊 CircleCI build failures summary and remediationsAs of commit ffee618: Commit ffee618 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 27 times. |
vishwakftw
approved these changes
Feb 25, 2020
Contributor
vishwakftw
left a comment
vishwakftw
left a comment
There was a problem hiding this comment.
Looks good to me, thank you.
Contributor
|
Are the docs failures normal? |
driazati
reviewed
Feb 25, 2020
| (torch._C._get_tracing_state, "aten::_get_tracing_state"), | ||
| (warnings.warn, "aten::warn"), | ||
| (torch._VF.stft, "aten::stft") | ||
| (torch._VF.stft, "aten::stft"), |
Contributor
There was a problem hiding this comment.
Why does something like _VF.dropout resolve without an explicit listing here but _VF.cdist does not?
Contributor
Author
There was a problem hiding this comment.
i think it's something to do with native schema bound ops name collision.
Contributor
Author
i think i just need to rename |
[ghstack-poisoned]
added 3 commits
February 26, 2020 10:34
[ghstack-poisoned]
Differential Revision: [D20121916](https://our.internmc.facebook.com/intern/diff/D20121916) [ghstack-poisoned]
Differential Revision: [D20121916](https://our.internmc.facebook.com/intern/diff/D20121916) [ghstack-poisoned]
Contributor
hczhu
pushed a commit
that referenced
this pull request
Feb 28, 2020
Summary: Pull Request resolved: #33737 Test Plan: Imported from OSS Differential Revision: D20121916 Pulled By: eellison fbshipit-source-id: b0427bbfd3ade1f3129c4a95a542fbc32c3abd76
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: Pull Request resolved: pytorch#33737 Test Plan: Imported from OSS Differential Revision: D20121916 Pulled By: eellison fbshipit-source-id: b0427bbfd3ade1f3129c4a95a542fbc32c3abd76
This was referenced Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D20121916