Skip to content

[C++ API] Add PackedSequence / pack_padded_sequence / pad_packed_sequence / pack_sequence #33652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yf225 wants to merge 12 commits into from
Closed

[C++ API] Add PackedSequence / pack_padded_sequence / pad_packed_sequence / pack_sequence #33652

yf225 wants to merge 12 commits into from

Conversation

@yf225
Copy link
Contributor

@yf225 yf225 commented Feb 22, 2020

Most of the function implementation and test code are translated from the Python version.

@yf225 yf225 added the module: cpp Related to C++ API label Feb 22, 2020
@yf225 yf225 requested review from pbelevich and removed request for ebetica and goldsborough February 22, 2020 05:07
facebook-github-bot
facebook-github-bot reviewed Feb 22, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yf225
Copy link
Contributor Author

yf225 commented Feb 22, 2020

TODO: need to debug PackedSequenceTest.To in CUDA

@yf225 yf225 removed the request for review from pbelevich February 22, 2020 05:42
@yf225 yf225 changed the title [C++ API] Add PackedSequence / pack_padded_sequence / pad_packed_sequence / pack_sequence [WIP] [C++ API] Add PackedSequence / pack_padded_sequence / pad_packed_sequence / pack_sequence Feb 22, 2020
@yf225 yf225 force-pushed the cpp_PackedSequence branch from c093aa9 to ee53eff Compare February 22, 2020 05:45
@dr-ci
Copy link

dr-ci bot commented Feb 22, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit ab64ee0:

None of the build failures appear to be your fault.

  • 1/1 recognized as flaky ❄️
    • Re-run these jobs?

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

❄️ 1 failure recognized as flaky

The following build failures have been detected as flaky and may not be your fault:

See CircleCI build pytorch_macos_10_13_py3_test (1/1)

Step: "Test" (full log | pattern match details) ❄️

Feb 24 15:15:15 RuntimeError: Process 0 terminated or timed out after 400.0841290950775 seconds 
Feb 24 15:15:15 ====================================================================== 
Feb 24 15:15:15 ERROR [400.118s]: test_autograd_context (__main__.DistAutogradTestWithSpawn) 
Feb 24 15:15:15 ---------------------------------------------------------------------- 
Feb 24 15:15:15 Traceback (most recent call last): 
Feb 24 15:15:15   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Feb 24 15:15:15     self._join_processes(fn) 
Feb 24 15:15:15   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_distributed.py", line 256, in _join_processes 
Feb 24 15:15:15     self._check_return_codes(elapsed_time) 
Feb 24 15:15:15   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_distributed.py", line 275, in _check_return_codes 
Feb 24 15:15:15     raise RuntimeError('Process {} terminated or timed out after {} seconds'.format(i, elapsed_time)) 
Feb 24 15:15:15 RuntimeError: Process 0 terminated or timed out after 400.0841290950775 seconds 
Feb 24 15:15:15  
Feb 24 15:15:15 ---------------------------------------------------------------------- 
Feb 24 15:15:15 Ran 54 tests in 469.200s 
Feb 24 15:15:15  
Feb 24 15:15:15 FAILED (errors=1, skipped=2) 
Feb 24 15:15:15  
Feb 24 15:15:15 Generating XML reports... 
Feb 24 15:15:15 Traceback (most recent call last): 
Feb 24 15:15:15   File "test/run_test.py", line 486, in <module> 
Feb 24 15:15:15     main()
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 27 times.

@yf225 yf225 force-pushed the cpp_PackedSequence branch from 5c7b698 to 6908b70 Compare February 22, 2020 17:48
@yf225 yf225 changed the title [WIP] [C++ API] Add PackedSequence / pack_padded_sequence / pad_packed_sequence / pack_sequence [C++ API] Add PackedSequence / pack_padded_sequence / pad_packed_sequence / pack_sequence Feb 23, 2020
@yf225 yf225 requested a review from pbelevich February 23, 2020 17:04
pbelevich
pbelevich approved these changes Feb 24, 2020
View reviewed changes
pbelevich
pbelevich suggested changes Feb 24, 2020
View reviewed changes
facebook-github-bot
facebook-github-bot reviewed Feb 24, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot
facebook-github-bot reviewed Feb 24, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@yf225 yf225 requested a review from pbelevich February 25, 2020 00:23
@yf225 yf225 mentioned this pull request Feb 25, 2020
Open
@yf225 yf225 mentioned this pull request Feb 25, 2020
Open
47 tasks
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 26, 2020

@yf225 merged this pull request in 0dded40.

hczhu pushed a commit that referenced this pull request Feb 28, 2020
[C++ API] Add PackedSequence / pack_padded_sequence / pad_packed_sequ…
189800d 
…ence / pack_sequence (#33652)

Summary:
Most of the function implementation and test code are translated from the Python version.
Pull Request resolved: #33652

Differential Revision: D20052211

Pulled By: yf225

fbshipit-source-id: ce6767db54364f91ef4f06674239a12278c2752a
ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
@ttumiel
[C++ API] Add PackedSequence / pack_padded_sequence / pad_packed_sequ…
3b4150f 
…ence / pack_sequence (pytorch#33652)

Summary:
Most of the function implementation and test code are translated from the Python version.
Pull Request resolved: pytorch#33652

Differential Revision: D20052211

Pulled By: yf225

fbshipit-source-id: ce6767db54364f91ef4f06674239a12278c2752a
@facebook-github-bot facebook-github-bot deleted the cpp_PackedSequence branch July 13, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

+1 more reviewer

@pbelevich pbelevich pbelevich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: cpp Related to C++ API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yf225 @facebook-github-bot @pbelevich @mruberry