Skip to content

[quant] Add Quantized BatchNorm2d module #33109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
supriyar wants to merge 8 commits into from
Closed

[quant] Add Quantized BatchNorm2d module #33109

supriyar wants to merge 8 commits into from

Conversation

@supriyar
Copy link
Contributor

@supriyar supriyar commented Feb 7, 2020 •
edited
Loading

Stack from ghstack:

Summary:

Test Plan:
python test/test_quantized_nn_mods.py ModuleAPITest.test_batch_norm

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D19861926

@supriyar
[quant] Add Quantized BatchNorm2d module
a29d686 
Summary:

Test Plan:
python test/test_quantized_nn_mods.py ModuleAPITest.test_batch_norm

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@supriyar supriyar requested a review from apaszke as a code owner February 7, 2020 22:24
@supriyar supriyar mentioned this pull request Feb 7, 2020
Closed
@supriyar
Update on "[quant] Add Quantized BatchNorm2d module"
4b38f00 
Summary:

Test Plan:
python test/test_quantized_nn_mods.py ModuleAPITest.test_batch_norm

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@dr-ci
Copy link

dr-ci bot commented Feb 7, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit 4786cc7:

None of the build failures appear to be your fault.

  • 1/2 broken upstream at merge base 03e9b9c since Feb 13

    Please rebase on the viable/strict branch (expand for instructions)

    If your commit is newer than viable/strict, you can try basing on an older, stable commit:

    git fetch origin viable/strict
git rebase --onto viable/strict $(git merge-base origin/master HEAD)

    If your commit is older than viable/strict:

    git fetch origin viable/strict
git rebase viable/strict

    Check out the recency history of this "viable master" tracking branch.

  • 1/2 recognized as flaky ❄️

    • Re-run these jobs?

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

❄️ 1 failure recognized as flaky

The following build failures have been detected as flaky and may not be your fault:

See CircleCI build caffe2_onnx_py2_gcc5_ubuntu16_04_test (1/1)

Step: "Test" (full log | pattern match details) ❄️

Feb 13 07:43:50 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_reshape /var/lib/jenkins/workspace/scripts/onnx/test.sh: line 57: 31078 Segmentation fault (core dumped) pytest "${args[@]}" --ignore "$top_dir/test/onnx/test_pytorch_onnx_onnxruntime.py" --ignore "$top_dir/test/onnx/test_custom_ops.py" --ignore "$top_dir/test/onnx/test_models_onnxruntime.py" "${test_paths[@]}" 
Feb 13 07:43:49 test/onnx/test_utility_funs.py::TestUtilityFuns_opset10::test_constant_fold_transpose_matmul PASSED [ 99%] 
Feb 13 07:43:49 test/onnx/test_utility_funs.py::TestUtilityFuns_opset10::test_constant_fold_unsqueeze PASSED [ 99%] 
Feb 13 07:43:49 test/onnx/test_utility_funs.py::TestUtilityFuns_opset10::test_error_on_data_parallel PASSED [ 99%] 
Feb 13 07:43:49 test/onnx/test_utility_funs.py::TestUtilityFuns_opset10::test_is_in_onnx_export PASSED [ 99%] 
Feb 13 07:43:49 test/onnx/test_utility_funs.py::TestUtilityFuns_opset10::test_strip_doc_string PASSED [ 99%] 
Feb 13 07:43:49 test/onnx/test_utility_funs.py::TestUtilityFuns_opset10::test_validate_dynamic_axes_invalid_input_output_name PASSED [ 99%] 
Feb 13 07:43:49 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_concat PASSED [ 99%] 
Feb 13 07:43:49 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_div PASSED [ 99%] 
Feb 13 07:43:49 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_lstm PASSED [ 99%] 
Feb 13 07:43:49 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_mul PASSED [ 99%] 
Feb 13 07:43:50 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_reshape /var/lib/jenkins/workspace/scripts/onnx/test.sh: line 57: 31078 Segmentation fault      (core dumped) pytest "${args[@]}" --ignore "$top_dir/test/onnx/test_pytorch_onnx_onnxruntime.py" --ignore "$top_dir/test/onnx/test_custom_ops.py" --ignore "$top_dir/test/onnx/test_models_onnxruntime.py" "${test_paths[@]}"

🚧 1 upstream failure recognized by patterns:

These builds matched patterns, but were probably caused by upstream breakages:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 13 times.

@supriyar
Update on "[quant] Add Quantized BatchNorm2d module"
c4137fb 
Summary:

Test Plan:
python test/test_quantized_nn_mods.py ModuleAPITest.test_batch_norm

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@supriyar
Update on "[quant] Add Quantized BatchNorm2d module"
67676a2 
Summary:

Test Plan:
python test/test_quantized_nn_mods.py ModuleAPITest.test_batch_norm

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
supriyar added a commit that referenced this pull request Feb 8, 2020
@supriyar
[quant] Add Quantized BatchNorm2d module
f67edc8 
Summary:

Test Plan:
python test/test_quantized_nn_mods.py ModuleAPITest.test_batch_norm

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: a5ce586
Pull Request resolved: #33109
@supriyar
Update on "[quant] Add Quantized BatchNorm2d module"
645d766 
Summary:

Test Plan:
python test/test_quantized_nn_mods.py ModuleAPITest.test_batch_norm

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@supriyar
Update on "[quant] Add Quantized BatchNorm2d module"
dc83a3e 
Summary:

Test Plan:
python test/test_quantized_nn_mods.py ModuleAPITest.test_batch_norm

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
supriyar added a commit that referenced this pull request Feb 11, 2020
@supriyar
[quant] Add Quantized BatchNorm2d module
b0878cb 
Summary:

Test Plan:
python test/test_quantized_nn_mods.py ModuleAPITest.test_batch_norm

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 9dac8cd
Pull Request resolved: #33109
@supriyar
Update on "[quant] Add Quantized BatchNorm2d module"
723f232 
Summary:

Test Plan:
python test/test_quantized_nn_mods.py ModuleAPITest.test_batch_norm

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D19861926](https://our.internmc.facebook.com/intern/diff/D19861926)

[ghstack-poisoned]
supriyar added a commit that referenced this pull request Feb 13, 2020
@supriyar
[quant] Add Quantized BatchNorm2d module
1ba91f5 
Summary:

Test Plan:
python test/test_quantized_nn_mods.py ModuleAPITest.test_batch_norm

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: c4e4a1d
Pull Request resolved: #33109
@supriyar
Update on "[quant] Add Quantized BatchNorm2d module"
4786cc7 
Summary:

Test Plan:
python test/test_quantized_nn_mods.py ModuleAPITest.test_batch_norm

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D19861926](https://our.internmc.facebook.com/intern/diff/D19861926)

[ghstack-poisoned]
supriyar added a commit that referenced this pull request Feb 13, 2020
@supriyar
[quant] Add Quantized BatchNorm2d module
f861d46 
Summary:

Test Plan:
python test/test_quantized_nn_mods.py ModuleAPITest.test_batch_norm

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 67c4fd7
Pull Request resolved: #33109
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 13, 2020

This pull request has been merged in 2e88d3d.

@facebook-github-bot facebook-github-bot deleted the gh/supriyar/55/head branch February 17, 2020 15:17
ttumiel pushed a commit to ttumiel/pytorch that referenced this pull request Mar 4, 2020
@supriyar @ttumiel
[quant] Add Quantized BatchNorm2d module (pytorch#33109)
3dd0dc2 
Summary: Pull Request resolved: pytorch#33109

Test Plan:
python test/test_quantized_nn_mods.py ModuleAPITest.test_batch_norm

Imported from OSS

Differential Revision: D19861926

fbshipit-source-id: 67315e49b4b3577b965d422ca707d927d977feeb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesr66a jamesr66a jamesr66a approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@raghuramank100 raghuramank100 Awaiting requested review from raghuramank100

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@supriyar @facebook-github-bot @jamesr66a @mruberry