C++/Python API Parity: add pad_sequence #32387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyashb95
requested review from
ebetica,
goldsborough and
yf225
as code owners
Contributor
Author
|
@yf225 lemme know if this is fine, I'm still working on the last test case |
yf225
added
module: cpp
💊 CircleCI build failures summary and remediationsAs of commit a2f4c15: Commit a2f4c15 was recently pushed. Waiting for builds... This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 37 times. |
- add `pad_sequence` and tests - related issue pytorch#25883
yf225
approved these changes
Feb 21, 2020
Contributor
yf225
left a comment
yf225
left a comment
There was a problem hiding this comment.
@suyash458 Thanks a lot for the awesome work!
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@yf225 Thanks for adding the final test! |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
Summary: - add `pad_sequence` and tests - related issue pytorch#25883 Pull Request resolved: pytorch#32387 Differential Revision: D20025421 Pulled By: yf225 fbshipit-source-id: caa9ae2114bece8db387a3a1610f24a3e06b1324
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pad_sequenceand tests