Add comments to torch::nn::ConvTranspose{1,2,3}d modules explaining how to use them in a Sequential module #32223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow to use them in a Sequential module
gchanan
approved these changes
Jan 15, 2020
Contributor
gchanan
left a comment
gchanan
left a comment
There was a problem hiding this comment.
just clean up the "can take" wording.
| /// learn about the exact behavior of this module. | ||
| /// | ||
| /// NOTE: `ConvTranspose1d` currently cannot be used in a `Sequential` module, | ||
| /// because `Sequential` module doesn't support modules with forward method that can take |
Contributor
There was a problem hiding this comment.
nit: "can take" is strange wording -- it does take it right? I.e. this should say "forward method that takes optional arguments"
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
…ow to use them in a Sequential module (pytorch#32223) Summary: Following changes in pytorch#31005. Pull Request resolved: pytorch#32223 Differential Revision: D19415328 Pulled By: yf225 fbshipit-source-id: f6f74f10ba3b5cc7e1a92f8b02ea4c9747018ae8
ttumiel
pushed a commit
to ttumiel/pytorch
that referenced
this pull request
Mar 4, 2020
…ow to use them in a Sequential module (pytorch#32223) Summary: Following changes in pytorch#31005. Pull Request resolved: pytorch#32223 Differential Revision: D19415328 Pulled By: yf225 fbshipit-source-id: f6f74f10ba3b5cc7e1a92f8b02ea4c9747018ae8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes in #31005.