Skip to content

Conversation

@jma127
Copy link
Contributor

@jma127 jma127 commented Jan 13, 2020

Follow-up of #27361 .

Addresses #32141 .

@gchanan
Copy link
Contributor

gchanan commented Jan 13, 2020

thanks for doing this!

@suo: want to argue we should use FutureWarning instead?

@suo
Copy link
Member

suo commented Jan 14, 2020

FutureWarning is (in 3.7+) supposed to be the class for user-facing warnings about deprecated features. So we might as well standardize on that; UserWarning is just the generic class and doesn't communicate anything special.

@jma127
Copy link
Contributor Author

jma127 commented Jan 14, 2020

Ran s/UserWarning/FutureWarning .

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gchanan is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@gchanan merged this pull request in 88c447b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants