Skip to content

remove .data from torch/jit #31480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
albanD wants to merge 4 commits into from
Closed

remove .data from torch/jit #31480

albanD wants to merge 4 commits into from

Conversation

@albanD
Copy link
Collaborator

@albanD albanD commented Dec 19, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D19303244

@albanD
remove .data from torch/jit
41685f1 
[ghstack-poisoned]
@albanD albanD requested a review from apaszke as a code owner December 19, 2019 17:31
This was referenced Dec 19, 2019
Closed
Closed
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Dec 19, 2019
@albanD albanD requested a review from gchanan December 19, 2019 17:35
@albanD albanD mentioned this pull request Dec 19, 2019
Closed
@kostmo
Copy link
Member

kostmo commented Dec 19, 2019 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit 500de03:

None of the build failures appear to be your fault.

  • 1/1 recognized as flaky ❄️
    • Re-run these jobs?

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

❄️ 1 failure recognized as flaky

The following build failures have been detected as flaky and may not be your fault:

See CircleCI build caffe2_onnx_py3_6_clang7_ubuntu16_04_test (1/1)

Step: "Test" (full log | pattern match details) ❄️

Jan 14 00:10:39 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_reshape Fatal Python error: Segmentation fault 
Jan 14 00:10:38 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_constant_fold_slice_negative_index PASSED [ 99%] 
Jan 14 00:10:38 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_constant_fold_transpose PASSED [ 99%] 
Jan 14 00:10:38 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_constant_fold_transpose_matmul PASSED [ 99%] 
Jan 14 00:10:38 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_constant_fold_unsqueeze PASSED [ 99%] 
Jan 14 00:10:38 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_error_on_data_parallel PASSED [ 99%] 
Jan 14 00:10:38 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_is_in_onnx_export PASSED [ 99%] 
Jan 14 00:10:38 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_strip_doc_string PASSED [ 99%] 
Jan 14 00:10:38 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_validate_dynamic_axes_invalid_input_output_name PASSED [ 99%] 
Jan 14 00:10:38 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_concat PASSED [ 99%] 
Jan 14 00:10:38 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_lstm PASSED [ 99%] 
Jan 14 00:10:39 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_reshape Fatal Python error: Segmentation fault 
Jan 14 00:10:39  
Jan 14 00:10:39 Current thread 0x00007fe54c29b700 (most recent call first): 
Jan 14 00:10:39   File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 43 in repr_instance 
Jan 14 00:10:39   File "/usr/lib/python3.6/reprlib.py", line 65 in repr1 
Jan 14 00:10:39   File "/usr/lib/python3.6/reprlib.py", line 55 in repr 
Jan 14 00:10:39   File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 36 in repr 
Jan 14 00:10:39   File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 67 in saferepr 
Jan 14 00:10:39   File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 655 in repr_args 
Jan 14 00:10:39   File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 736 in repr_traceback_entry 
Jan 14 00:10:39   File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 777 in repr_traceback
This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 12 times.

@albanD albanD requested a review from zdevito January 7, 2020 21:20
gchanan
gchanan reviewed Jan 9, 2020
View reviewed changes
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 14, 2020

@albanD merged this pull request in c036fbd.

@facebook-github-bot facebook-github-bot deleted the gh/albanD/20/head branch January 18, 2020 15:17
wuhuikx pushed a commit to wuhuikx/pytorch that referenced this pull request Jan 30, 2020
@albanD @facebook-github-bot
remove .data from torch/jit
db1636f 
Summary: Pull Request resolved: pytorch#31480

Test Plan: Imported from OSS

Differential Revision: D19303244

Pulled By: albanD

fbshipit-source-id: ec66b32353f2f9b16072185ecde3ae8abbe09a35
@albanD albanD mentioned this pull request Feb 7, 2020
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gchanan gchanan gchanan approved these changes

@zdevito zdevito zdevito approved these changes

@apaszke apaszke Awaiting requested review from apaszke

Assignees

No one assigned

Labels

Merged oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@albanD @kostmo @facebook-github-bot @zdevito @gchanan @mruberry