Fix unflatten when dim is a negative integer #31208
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog: - Wrap dim to be a positive integer when dim is negative Test plan: - Updated tests in test_namedtensor.py
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@zou3519 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@zou3519 is this good to go? I see some failing internals tests. |
Contributor
|
@vishwakftw Yeah this should be good to go. I'm going to trigger the land again |
Contributor
vishwakftw
added a commit
to vishwakftw/pytorch
that referenced
this pull request
Dec 18, 2019
Summary: Changelog: - Wrap dim to be a positive integer when dim is negative Pull Request resolved: pytorch#31208 Test Plan: - Updated tests in test_namedtensor.py Fixes pytorch#31184 Differential Revision: D19036569 Pulled By: zou3519 fbshipit-source-id: 86e01e20988dee7c4b6c73232f66282d687f9a2c
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Changelog: - Wrap dim to be a positive integer when dim is negative Pull Request resolved: pytorch#31208 Test Plan: - Updated tests in test_namedtensor.py Fixes pytorch#31184 Differential Revision: D19036569 Pulled By: zou3519 fbshipit-source-id: 86e01e20988dee7c4b6c73232f66282d687f9a2c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog:
Test plan:
Fixes #31184