Remove namespace F = torch::nn::functional from torch/nn/modules/batchhnorm.h #30684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbelevich
approved these changes
Dec 3, 2019
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@yf225 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
albanD
approved these changes
Dec 3, 2019
yf225
pushed a commit
that referenced
this pull request
Dec 3, 2019
…hhnorm.h (#30684) Summary: This PR removes `namespace F = torch::nn::functional` from `torch/nn/modules/batchhnorm.h`, so that people don't have to define `torch::nn::functional` as `F` if they don't want to. Fixes #30682. Pull Request resolved: #30684 Differential Revision: D18795717 Pulled By: yf225 fbshipit-source-id: c9feffbeb632cc6b4ce3e6c22c0a78533bab69ad
yf225
pushed a commit
that referenced
this pull request
Dec 4, 2019
…hhnorm.h (#30684) Summary: This PR removes `namespace F = torch::nn::functional` from `torch/nn/modules/batchhnorm.h`, so that people don't have to define `torch::nn::functional` as `F` if they don't want to. Fixes #30682. Pull Request resolved: #30684 Differential Revision: D18795717 Pulled By: yf225 fbshipit-source-id: c9feffbeb632cc6b4ce3e6c22c0a78533bab69ad
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
…hhnorm.h (pytorch#30684) Summary: This PR removes `namespace F = torch::nn::functional` from `torch/nn/modules/batchhnorm.h`, so that people don't have to define `torch::nn::functional` as `F` if they don't want to. Fixes pytorch#30682. Pull Request resolved: pytorch#30684 Differential Revision: D18795717 Pulled By: yf225 fbshipit-source-id: c9feffbeb632cc6b4ce3e6c22c0a78533bab69ad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
namespace F = torch::nn::functionalfromtorch/nn/modules/batchhnorm.h, so that people don't have to definetorch::nn::functionalasFif they don't want to.Fixes #30682.