Raise an error for is_signed on quantized types #30527
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: When we introduced dtype.is_signed we allowed for support of quantized types, but we're not sure what the correct result should be. See discussion at #29511 [ghstack-poisoned]
albanD
reviewed
Nov 27, 2019
Summary: When we introduced dtype.is_signed we allowed for support of quantized types, but we're not sure what the correct result should be. See discussion at #29511 [ghstack-poisoned]
albanD
approved these changes
Dec 2, 2019
Summary: When we introduced dtype.is_signed we allowed for support of quantized types, but we're not sure what the correct result should be. See discussion at #29511 [ghstack-poisoned]
Summary: When we introduced dtype.is_signed we allowed for support of quantized types, but we're not sure what the correct result should be. See discussion at #29511 Differential Revision: [D18765410](https://our.internmc.facebook.com/intern/diff/D18765410)
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
Summary: Pull Request resolved: pytorch#30527 When we introduced dtype.is_signed we allowed for support of quantized types, but we're not sure what the correct result should be. See discussion at pytorch#29511 Test Plan: Imported from OSS Differential Revision: D18765410 Pulled By: nairbv fbshipit-source-id: c87cfe999b604cfcbbafa561e04d0d5cdbf41e6d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
When we introduced dtype.is_signed we allowed for support of
quantized types, but we're not sure what the correct result should be.
See discussion at #29511
Differential Revision: D18765410