[pytorch][ci] add mobile build CI with host toolchain #30292
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We already have CI jobs to build Android/iOS libraries, but there are two issues: - It's no easy for people who are not regularly working on mobile to debug these CI errors as they need setup Android/iOS build environment; - It's hard to run cross-compiled mobile libraries as it requires emulator. It happened a couple times recently that it can build but fail to load and run a model with mobile build. To address these problems, create this new CI job to build mobile library with linux host toolchain so that we can build & test without involving Android/iOS environment/simulator. Will add tests on top of it next. Test Plan: - check the new CI job [ghstack-poisoned]
Summary: We already have CI jobs to build Android/iOS libraries, but there are two issues: - It's no easy for people who are not regularly working on mobile to debug these CI errors as they need setup Android/iOS build environment; - It's hard to run cross-compiled mobile libraries as it requires emulator. It happened a couple times recently that it can build but fail to load and run a model with mobile build. To address these problems, create this new CI job to build mobile library with linux host toolchain so that we can build & test without involving Android/iOS environment/simulator. Will add tests on top of it next. Test Plan: - check the new CI job Differential Revision: [D18654074](https://our.internmc.facebook.com/intern/diff/D18654074) [ghstack-poisoned]
ljk53
added a commit
that referenced
this pull request
Nov 22, 2019
Summary: We already have CI jobs to build Android/iOS libraries, but there are two issues: - It's no easy for people who are not regularly working on mobile to debug these CI errors as they need setup Android/iOS build environment; - It's hard to run cross-compiled mobile libraries as it requires emulator. It happened a couple times recently that it can build but fail to load and run a model with mobile build. To address these problems, create this new CI job to build mobile library with linux host toolchain so that we can build & test without involving Android/iOS environment/simulator. Will add tests on top of it next. Test Plan: - check the new CI job ghstack-source-id: bcbecb5 Pull Request resolved: #30292
dreiss
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
We already have CI jobs to build Android/iOS libraries, but there are
two issues:
these CI errors as they need setup Android/iOS build environment;
emulator. It happened a couple times recently that it can build but fail
to load and run a model with mobile build.
To address these problems, create this new CI job to build mobile
library with linux host toolchain so that we can build & test without
involving Android/iOS environment/simulator. Will add tests on top of it next.
Test Plan:
Differential Revision: D18654074