[pytorch][mobile] disable JIT optimizer in Android wrapper for mobile custom build #30285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… custom build Summary: PR #30144 introduced custom build script to tailor build to specific models. It requires a list of all potentially used ops at build time. Some JIT optimization passes can transform the IR by replacing operators, e.g. decompose pass can replace aten::addmm with aten::mm if coefficients are 1s. Disabling optimization pass can ensure that the list of ops we dump from the model is the list of ops that are needed. Test Plan: - rerun the test on PR #30144 to verify the raw list without aten::mm works. [ghstack-poisoned]
ljk53
added a commit
that referenced
this pull request
Nov 22, 2019
… custom build Summary: PR #30144 introduced custom build script to tailor build to specific models. It requires a list of all potentially used ops at build time. Some JIT optimization passes can transform the IR by replacing operators, e.g. decompose pass can replace aten::addmm with aten::mm if coefficients are 1s. Disabling optimization pass can ensure that the list of ops we dump from the model is the list of ops that are needed. Test Plan: - rerun the test on PR #30144 to verify the raw list without aten::mm works. ghstack-source-id: 28e4a40 Pull Request resolved: #30285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
PR #30144 introduced custom build script to tailor build to specific
models. It requires a list of all potentially used ops at build time.
Some JIT optimization passes can transform the IR by replacing
operators, e.g. decompose pass can replace aten::addmm with aten::mm if
coefficients are 1s.
Disabling optimization pass can ensure that the list of ops we dump from
the model is the list of ops that are needed.
Test Plan:
Differential Revision: D18652777