-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Remove use of .data in optimizers #30258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
vincentqb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Differential Revision: [D18665459](https://our.internmc.facebook.com/intern/diff/D18665459) [ghstack-poisoned]
ghstack-source-id: 6aaf2a2 Pull Request resolved: pytorch#30258
|
Is this test related? It doesn't seem to be to me. |
|
I was looking into the tests. But I need a multigpu box to test. So it's taking some time to get running. |
ghstack-source-id: 6aaf2a2 Pull Request resolved: pytorch#30258
|
After investigation, the problem is the same as: #13452 (comment) |
vincentqb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Causes issues in #30334 ? Thanks for identifying this.
|
Closing this until we fix the Broadcast issue described in #13452 (comment) |
Stack from ghstack:
Differential Revision: D18665459