Make all optimizers consistent so that they don't change gradients inplace #30257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…place [ghstack-poisoned]
…radients inplace" [ghstack-poisoned]
albanD
added a commit
to albanD/pytorch
that referenced
this pull request
Nov 21, 2019
…place ghstack-source-id: fc2b62a Pull Request resolved: pytorch#30257
This was referenced Nov 22, 2019
anjali411
approved these changes
Nov 22, 2019
Contributor
|
Flagged as BC breaking. As we discussed offline, since the gradient used to be modified in place, the gradient might have been different after running the |
albanD
added a commit
to albanD/pytorch
that referenced
this pull request
Nov 25, 2019
…place ghstack-source-id: fc2b62a Pull Request resolved: pytorch#30257
wuhuikx
pushed a commit
to wuhuikx/pytorch
that referenced
this pull request
Jan 30, 2020
…place Summary: Pull Request resolved: pytorch#30257 Test Plan: Imported from OSS Differential Revision: D18665461 Pulled By: albanD fbshipit-source-id: cfdafef919468a41007881b82fd288b7128baf95
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 9, 2024
Fixes #38006 The note was originally added in #30257, which tried to ensure that the gradient wasn't modified in the optimizer. This note creates more confusion than is helpful, so removing it is better than leaving it in, especially because most uses of closure that I know _does_ modify the grads. Pull Request resolved: #137535 Approved by: https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18665461