[rpc] default construct rpc agent options based on the backend type #30201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a default constructor so that users don't have to construct RPC agent options. Also rename this to RPCBackend Options as suggested. Differential Revision: [D18628698](https://our.internmc.facebook.com/intern/diff/D18628698/) [ghstack-poisoned]
rohan-varma
requested review from
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
xush6528
approved these changes
Nov 21, 2019
torch/distributed/rpc/api.py
Outdated
| # default construct a set of RPC agent options. | ||
| rpc_agent_options = rpc.backend_registry.construct_rpc_agent_options( | ||
| backend | ||
| ) |
Contributor
There was a problem hiding this comment.
Make sense.
construct_rpc_agent_options handlers should provide defaults in Python world.
xush6528
requested changes
Nov 21, 2019
Contributor
xush6528
left a comment
xush6528
left a comment
There was a problem hiding this comment.
Noticed your PR summary and you want to do the renaming as well.
…e backend type" Provide a default constructor so that users don't have to construct RPC agent options. Also rename this to RPCBackend Options as suggested. Differential Revision: [D18628698](https://our.internmc.facebook.com/intern/diff/D18628698/) [ghstack-poisoned]
…e backend type" Provide a default constructor so that users don't have to construct RPC agent options. Also rename this to RPCBackend Options as suggested. Differential Revision: [D18628698](https://our.internmc.facebook.com/intern/diff/D18628698/) [ghstack-poisoned]
…e backend type" Provide a default constructor so that users don't have to construct RPC agent options. Also rename this to RPCBackend Options as suggested. Differential Revision: [D18628698](https://our.internmc.facebook.com/intern/diff/D18628698/) [ghstack-poisoned]
…e backend type" Provide a default constructor so that users don't have to construct RPC agent options. Also rename this to RPCBackend Options as suggested. Differential Revision: [D18628698](https://our.internmc.facebook.com/intern/diff/D18628698/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 21, 2019
Pull Request resolved: #30201 Provide a default constructor so that users don't have to construct RPC agent options. Also rename this to RPCBackend Options as suggested. ghstack-source-id: 94321742 Differential Revision: [D18628698](https://our.internmc.facebook.com/intern/diff/D18628698/)
…e backend type" Provide a default constructor so that users don't have to construct RPC agent options. Also rename this to RPCBackend Options as suggested. Differential Revision: [D18628698](https://our.internmc.facebook.com/intern/diff/D18628698/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 21, 2019
Pull Request resolved: #30201 Provide a default constructor so that users don't have to construct RPC agent options. Also rename this to RPCBackend Options as suggested. ghstack-source-id: 94323760 Differential Revision: [D18628698](https://our.internmc.facebook.com/intern/diff/D18628698/)
…e backend type" Provide a default constructor so that users don't have to construct RPC agent options. Also rename this to RPCBackend Options as suggested. Differential Revision: [D18628698](https://our.internmc.facebook.com/intern/diff/D18628698/) [ghstack-poisoned]
rohan-varma
changed the title
mrshenli
reviewed
Nov 21, 2019
| ) | ||
| if not rpc_backend_options: | ||
| # default construct a set of RPC agent options. | ||
| rpc_backend_options = rpc.backend_registry.construct_rpc_backend_options( |
…kend type" Provide a default constructor so that users don't have to construct RPC agent options. Also rename this to RPCBackend Options as suggested. Differential Revision: [D18628698](https://our.internmc.facebook.com/intern/diff/D18628698/) [ghstack-poisoned]
rohan-varma
added a commit
that referenced
this pull request
Nov 22, 2019
Pull Request resolved: #30201 Provide a default constructor so that users don't have to construct RPC agent options. Also rename this to RPCBackend Options as suggested. ghstack-source-id: 94406842 Differential Revision: [D18628698](https://our.internmc.facebook.com/intern/diff/D18628698/)
…kend type" Provide a default constructor so that users don't have to construct RPC agent options. Also rename this to RPCBackend Options as suggested. Differential Revision: [D18628698](https://our.internmc.facebook.com/intern/diff/D18628698/) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Provide a default constructor so that users don't have to construct
RPC agent options. Also rename this to RPCBackend Options as suggested.
Differential Revision: D18628698