Add RPC internal helper that overrides the default pickler. #30173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzwen
requested review from
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18621372 |
Contributor
|
This is retrying #30107 as the previous PR failed to sync with phab |
Summary: Pull Request resolved: #30173 To enable share_memory over RPC, add an internal helper that overrides the default RPC pickler. Replace D18598974 Test Plan: `python test/test_rpc_spawn RpcTestWithSpawn.test_use_rpc_pickler` `buck test mode/dev-nosan //caffe2/test:rpc_spawn -- test_use_rpc_pickler` Differential Revision: D18621372 fbshipit-source-id: cdfe28732025ce1f904c9c1ef92b0bb5bd6c0219
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D18621372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To enable share_memory over RPC, add an internal helper that overrides the default RPC pickler.
Replace D18598974
Test Plan:
python test/test_rpc_spawn RpcTestWithSpawn.test_use_rpc_picklerDifferential Revision: D18621372