ONNX Hardtanh Opset 11 Support #30169
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@houseroad has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@houseroad, are the failure in "Facebook Internal - Builds & Tests" related to this PR? |
houseroad
approved these changes
Nov 21, 2019
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 28, 2020
Summary: Oneline fix to lara-hdr 's PR #30169. Default `dtype` value should be set when `dtype is None` rather than when `dtype is not None`. I didn't make an issue for this as such a small change but I have been using this locally in order to export a model with opset 11 (opset 10 still works). Pull Request resolved: #35467 Differential Revision: D20686048 Pulled By: mruberry fbshipit-source-id: 726a5f9c0711c7a79b171fe98b602cdef27f9b31
gchanan
pushed a commit
to gchanan/pytorch
that referenced
this pull request
Apr 7, 2020
…#35467) Summary: Oneline fix to lara-hdr 's PR pytorch#30169. Default `dtype` value should be set when `dtype is None` rather than when `dtype is not None`. I didn't make an issue for this as such a small change but I have been using this locally in order to export a model with opset 11 (opset 10 still works). Pull Request resolved: pytorch#35467 Differential Revision: D20686048 Pulled By: mruberry fbshipit-source-id: 726a5f9c0711c7a79b171fe98b602cdef27f9b31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for hardtanh that was blacklisted in opset 11.