Skip to content

[android][fbjni] fbjni gradle obey ABI_FILTERS parameter #30135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
IvanKobzarev wants to merge 1 commit into from
Closed

[android][fbjni] fbjni gradle obey ABI_FILTERS parameter #30135

IvanKobzarev wants to merge 1 commit into from

Conversation

@IvanKobzarev
Copy link
Contributor

@IvanKobzarev IvanKobzarev commented Nov 20, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D18610031

Obey the same gradle parameter as for pytorch_andrpod/build.gradle for android.ndk.abiFilters - ABI_FILTERS
To build and package only specified abis

To test:

gradle -p android -PABI_FILTERS=armeabi-v7a clean assembleDebug

└─ $ unzip -l ./android/pytorch_android/build/outputs/aar/pytorch_android-1.4.0-SNAPSHOT.aar
Archive:  ./android/pytorch_android/build/outputs/aar/pytorch_android-1.4.0-SNAPSHOT.aar
  Length      Date    Time    Name
---------  ---------- -----   ----
      269  02-01-1980 00:00   AndroidManifest.xml
    81895  02-01-1980 00:00   R.txt
    16368  02-01-1980 00:00   classes.jar
        0  02-01-1980 00:00   res/
        0  02-01-1980 00:00   res/values/
      116  02-01-1980 00:00   res/values/values.xml
        0  02-01-1980 00:00   jni/
        0  02-01-1980 00:00   jni/armeabi-v7a/
   579412  02-01-1980 00:00   jni/armeabi-v7a/libfbjni.so
 14854872  02-01-1980 00:00   jni/armeabi-v7a/libpytorch_jni.so
        0  02-01-1980 00:00   values/
        0  02-01-1980 00:00   armeabi-v7a/
---------                     -------
 15532932                     12 files

IvanKobzarev added a commit that referenced this pull request Nov 20, 2019
@IvanKobzarev
[android][fbjni] fbjni gradle obey ABI_FILTERS parameter
8def912 
ghstack-source-id: 311ed78
Pull Request resolved: #30135
@IvanKobzarev IvanKobzarev requested review from dreiss and ljk53 November 20, 2019 02:35
ljk53
ljk53 approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@ljk53 ljk53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2019

@IvanKobzarev merged this pull request in 1b26e3f.

@facebook-github-bot facebook-github-bot deleted the gh/IvanKobzarev/24/head branch November 23, 2019 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dreiss dreiss Awaiting requested review from dreiss

1 more reviewer

@ljk53 ljk53 ljk53 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IvanKobzarev @facebook-github-bot @ljk53 @mruberry