[iOS] add unit tests to iOS CI jobs #30133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xta0
changed the title
xta0
changed the title
xta0
changed the title
xta0
commented
Nov 21, 2019
| PROJ_ROOT=/Users/distiller/project | ||
| source ~/anaconda/bin/activate | ||
| #install the latest version of PyTorch and TorchVision | ||
| #TODO: How to install the nightly build? |
Contributor
Author
There was a problem hiding this comment.
@ezyang is it possible to install a PyTorch nightly build on MacOS via pip? I searched a lil bit, didn't find the right command to do it. The goal here is to use a recent (up-to-date) version of PyTorch to generate a torchscript model for the iOS TestApp to test.
Contributor
There was a problem hiding this comment.
Something like:
pip install --pre torch torchvision -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html
as suggested in https://pytorch.org/get-started/locally/
shoumikhin
approved these changes
Nov 21, 2019
xta0
changed the title
ljk53
reviewed
Nov 21, 2019
.circleci/config.yml
Outdated
| - should_run_job | ||
| - checkout | ||
| - run_brew_for_ios_build | ||
| - run_brew_for_ios_build |
ezyang
reviewed
Nov 21, 2019
| _module.eval(); | ||
| std::vector<c10::IValue> inputs; | ||
| inputs.push_back(torch::ones({1, 3, 224, 224}, at::ScalarType::Float)); | ||
| torch::autograd::AutoGradMode guard(false); |
Contributor
There was a problem hiding this comment.
Yes, the old RAII use didn't do anything :P
Contributor
|
I'm a little concerned about relying on nightlies for per PR tests, because it means that a botched nightly build will break all signal on this job, and you won't have any easy remediation. In this sense, it is almost better to use the official build, which will rev much less frequently. However, the official build is only really OK if we maintain backwards-compatibility (which we should be, right @houseroad ?) So I feel the patch as is is better. |
ezyang
approved these changes
Nov 21, 2019
### Summary Recently we've found that the master branch was constantly broken due to some unwanted change being landed on mobile. The problem is that our CI was not able to detect the runtime errors. ### Previous work - Add an unit test target to the iOS TestApp ( #29962 ) - Update Fastlane to run tests ( #29963 ) ### What's been changed in CI 1. XCode version has been updated to 11.2.1 2. For iOS simulator build, we'll run some unit tests( currently only one) after the build test. Differential Revision: [D18641413](https://our.internmc.facebook.com/intern/diff/D18641413)
### Summary Recently we've found that the master branch was constantly broken due to some unwanted change being landed on mobile. The problem is that our CI was not able to detect the runtime errors. ### Previous work - Add an unit test target to the iOS TestApp ( #29962 ) - Update Fastlane to run tests ( #29963 ) ### What's been changed in CI 1. XCode version has been updated to 11.2.1 2. For iOS simulator build, we'll run some unit tests( currently only one) after the build test. Differential Revision: [D18641413](https://our.internmc.facebook.com/intern/diff/D18641413)
### Summary Recently we've found that the master branch was constantly broken due to some unwanted change being landed on mobile. The problem is that our CI was not able to detect the runtime errors. ### Previous work - Add an unit test target to the iOS TestApp ( #29962 ) - Update Fastlane to run tests ( #29963 ) ### What's been changed in CI 1. XCode version has been updated to 11.2.1 2. For iOS simulator build, we'll run some unit tests( currently only one) after the build test. Differential Revision: [D18641413](https://our.internmc.facebook.com/intern/diff/D18641413)
### Summary Recently we've found that the master branch was constantly broken due to some unwanted change being landed on mobile. The problem is that our CI was not able to detect the runtime errors. ### Previous work - Add an unit test target to the iOS TestApp ( #29962 ) - Update Fastlane to run tests ( #29963 ) ### What's been changed in CI 1. XCode version has been updated to 11.2.1 2. For iOS simulator build, we'll run some unit tests( currently only one) after the build test. Differential Revision: [D18641413](https://our.internmc.facebook.com/intern/diff/D18641413)
Contributor
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
Recently we've found that the master branch was constantly broken due to some unwanted change being landed on mobile. The problem is that our CI was not able to detect the runtime errors.
Previous work
What's been changed in CI
Differential Revision: D18641413