Skip to content

Add RPC internal helper that overrides the default pickler #30107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zzzwen wants to merge 1 commit into from
Closed

Add RPC internal helper that overrides the default pickler #30107

zzzwen wants to merge 1 commit into from

Conversation

@zzzwen
Copy link
Contributor

@zzzwen zzzwen commented Nov 19, 2019 •
edited
Loading

Summary: To enable share_memory over RPC, add an internal helper that overrides the default RPC pickler

Test Plan: python test/test_rpc_spawn RpcTestWithSpawn.test_use_rpc_pickler

Differential Revision: D18598974

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 19, 2019

This pull request was exported from Phabricator. Differential Revision: D18598974

mrshenli
mrshenli reviewed Nov 19, 2019
View reviewed changes
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 19, 2019

This pull request was exported from Phabricator. Differential Revision: D18598974

mrshenli
mrshenli reviewed Nov 19, 2019
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added some nits. Will stamp when test pass.

test/rpc_test.py Outdated
Copy link
Contributor

@mrshenli mrshenli Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move one line above

torch/distributed/rpc/api.py Outdated
Copy link
Contributor

@mrshenli mrshenli Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, any reason for using camel here?

@rohan-varma
Copy link
Contributor

rohan-varma commented Nov 19, 2019 •
edited
Loading

Could you update the test plan with how an OSS user could run this test? Something like python test/test_rpc_spawn RpcTestWithSpawn.test_use_rpc_pickler would be great

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 19, 2019

This pull request was exported from Phabricator. Differential Revision: D18598974

@facebook-github-bot
Add RPC internal helper that overrides the default pickler (#30107)
1a087b9 
Summary:
Pull Request resolved: #30107

To enable share_memory over RPC, add an internal helper that overrides the default RPC pickler

Test Plan: `buck test mode/dev-nosan //caffe2/test:rpc_spawn -- test_use_rpc_pickler`

Differential Revision: D18598974

fbshipit-source-id: d5a6583e94f1c98fa0db2c1d6f0e66ff5c6141d9
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 19, 2019

This pull request was exported from Phabricator. Differential Revision: D18598974

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2019

This pull request was exported from Phabricator. Differential Revision: D18598974

mrshenli
mrshenli approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests passed but there are conflicts in rpc_test.py. Please address and make sure tests pass after that before landing.

pietern
pietern suggested changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing approval until the conflict is resolved and tests pass.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2019

This pull request was exported from Phabricator. Differential Revision: D18598974

2 similar comments
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2019

This pull request was exported from Phabricator. Differential Revision: D18598974

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2019

This pull request was exported from Phabricator. Differential Revision: D18598974

@zzzwen
Copy link
Contributor Author

zzzwen commented Nov 20, 2019

Github does not pickup the rebased version. Close this PR and re-exporting...

@zzzwen zzzwen closed this Nov 20, 2019
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2019

This pull request was exported from Phabricator. Differential Revision: D18598974

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2019

This pull request was exported from Phabricator. Differential Revision: D18598974

@zzzwen
Copy link
Contributor Author

zzzwen commented Nov 20, 2019

Reopen as #30173

@mrshenli mrshenli mentioned this pull request Nov 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli mrshenli approved these changes

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

+1 more reviewer

@pietern pietern pietern requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zzzwen @facebook-github-bot @rohan-varma @pietern @mrshenli