Skip to content

C++ API parity: isfinite #30083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pbelevich wants to merge 4 commits into from
Closed

C++ API parity: isfinite #30083

pbelevich wants to merge 4 commits into from

Conversation

@pbelevich
Copy link
Contributor

@pbelevich pbelevich commented Nov 19, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D18594723

@pbelevich
C++ API parity: isfinite
fd6e39d 
[ghstack-poisoned]
@pbelevich pbelevich mentioned this pull request Nov 19, 2019
Closed
@pbelevich pbelevich requested review from zou3519 and removed request for ebetica and goldsborough November 19, 2019 16:23
zdevito pushed a commit to zdevito/ATen that referenced this pull request Nov 20, 2019
@pbelevich @facebook-github-bot
C++ API parity: isfinite
d04df53 
Summary: Pull Request resolved: pytorch/pytorch#30083

Test Plan: Imported from OSS

Differential Revision: D18594723

Pulled By: pbelevich

fbshipit-source-id: 5970e0aa6ef8994e9c4a741784fd053383aaceb7
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2019

@pbelevich merged this pull request in cc81769.

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 20, 2019

@pbelevich merged this pull request in cc81769.

@jjlilley
Copy link

jjlilley commented Nov 20, 2019

Wondering, I see the following when I run tests on caffe2/tests/...

File "/data/users/jeremyl/fbsource/fbcode/buck-out/dev/gen/caffe2/test/rpc_fork#binary,link-tree/torch/_torch_docs.py", line 2415, in
add_docstr(torch.isfinite,
AttributeError: module 'torch' has no attribute 'isfinite'

Is this related?

@zou3519
Copy link
Contributor

zou3519 commented Nov 20, 2019

cc @ailzhang the xla CI was red on this and it seems to be failing on master in the same way, do you know what could be up here?

@zou3519
Copy link
Contributor

zou3519 commented Nov 20, 2019

Wondering, I see the following when I run tests on caffe2/tests/...

File "/data/users/jeremyl/fbsource/fbcode/buck-out/dev/gen/caffe2/test/rpc_fork#binary,link-tree/torch/_torch_docs.py", line 2415, in
add_docstr(torch.isfinite,
AttributeError: module 'torch' has no attribute 'isfinite'

Is this related?

@jjlilley A clean and a rebuild might fix the problem; The python bindings for isfinite now gets autogenerated

@jjlilley
Copy link

jjlilley commented Nov 20, 2019

Ah, thanks, I should have tried that earlier

@ailzhang
Copy link
Contributor

ailzhang commented Nov 20, 2019

Thanks @zou3519! @mruberry has temporarily disabled this test on XLA side. And we're trying to investigate the root cause.
@pbelevich Ideally a PR that breaking XLA test should notify us before it's merged ;). The easiest way is to open an issue in pytorch/xla and link the broken PR. That way we'll have more time to prepare a fix. Thanks!

@facebook-github-bot facebook-github-bot deleted the gh/pbelevich/56/head branch November 23, 2019 15:16
@suo suo mentioned this pull request Dec 10, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yf225 yf225 yf225 approved these changes

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@pbelevich @facebook-github-bot @jjlilley @zou3519 @ailzhang @yf225 @mruberry