Polish rpc docstring. #30069
Closed
Polish rpc docstring. #30069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Fix rpc docstrings 2) Fix some links Differential Revision: [D18588231](https://our.internmc.facebook.com/intern/diff/D18588231/) [ghstack-poisoned]
pritamdamania87
requested review from
mrshenli and
zhaojuanmao
as code owners
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 19, 2019
1) Fix rpc docstrings 2) Fix some links Differential Revision: [D18588231](https://our.internmc.facebook.com/intern/diff/D18588231/) ghstack-source-id: 94176354 Pull Request resolved: #30069
mrshenli
reviewed
Nov 19, 2019
Contributor
mrshenli
left a comment
mrshenli
left a comment
There was a problem hiding this comment.
Could you please post a snapshot of the result?
1) Fix rpc docstrings 2) Fix some links Differential Revision: [D18588231](https://our.internmc.facebook.com/intern/diff/D18588231/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 19, 2019
Pull Request resolved: #30069 1) Fix rpc docstrings 2) Fix some links ghstack-source-id: 94200205 Differential Revision: [D18588231](https://our.internmc.facebook.com/intern/diff/D18588231/)
Contributor
Author
|
I've uploaded screenshots although it might be easier to patch the PR locally and view it in your browser.
|
mrshenli
approved these changes
Nov 19, 2019
Contributor
mrshenli
left a comment
mrshenli
left a comment
There was a problem hiding this comment.
API change looks good to me. Thanks!
One test failure is irrelevant:
Nov 19 19:31:52 ======================================================================
Nov 19 19:31:52 FAIL: test_mnist_cuda (jit.test_models.TestModels)
Nov 19 19:31:52 ----------------------------------------------------------------------
Nov 19 19:31:52 Traceback (most recent call last):
Nov 19 19:31:52 File "/var/lib/jenkins/workspace/test/common_utils.py", line 610, in wrapper
Nov 19 19:31:52 method(*args, **kwargs)
Nov 19 19:31:52 File "/var/lib/jenkins/workspace/test/common_utils.py", line 494, in __exit__
Nov 19 19:31:52 self.name, after - before, i))
Nov 19 19:31:52 File "/var/lib/jenkins/workspace/test/common_utils.py", line 815, in assertEqual
Nov 19 19:31:52 super(TestCase, self).assertLessEqual(abs(x - y), prec, message)
Nov 19 19:31:52 AssertionError: 63488 not less than or equal to 1e-05 : jit.test_models.TestModels.test_mnist_cuda leaked 63488 bytes CUDA memory on device 0
Another test failure will disappear after a rebase:
19:26:47 ======================================================================
19:26:47 ERROR: test_rpc_return_rref (__main__.RpcTestWithFork)
19:26:47 ----------------------------------------------------------------------
19:26:47 Traceback (most recent call last):
19:26:47 File "/var/lib/jenkins/workspace/test/common_distributed.py", line 130, in wrapper
19:26:47 self._join_processes(fn)
19:26:47 File "/var/lib/jenkins/workspace/test/common_distributed.py", line 211, in _join_processes
19:26:47 self._check_return_codes(elapsed_time)
19:26:47 File "/var/lib/jenkins/workspace/test/common_distributed.py", line 230, in _check_return_codes
19:26:47 raise RuntimeError('Process {} terminated or timed out after {} seconds'.format(i, elapsed_time))
19:26:47 RuntimeError: Process 0 terminated or timed out after 300.2686879634857 seconds
BTW, I use chrome plugin to take snapshot of the entire webpage (e.g)
|
|
||
| .. _distributed-autograd-design: | ||
|
|
||
| .. warning:: |
Contributor
There was a problem hiding this comment.
Removing this because it is already mentioned in the API doc?
Contributor
Author
There was a problem hiding this comment.
It is actually repeated two lines above (probably was repeated while merging conflicts).
1) Fix rpc docstrings 2) Fix some links Differential Revision: [D18588231](https://our.internmc.facebook.com/intern/diff/D18588231/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 19, 2019
Pull Request resolved: #30069 1) Fix rpc docstrings 2) Fix some links ghstack-source-id: 94225628 Differential Revision: [D18588231](https://our.internmc.facebook.com/intern/diff/D18588231/)
1) Fix rpc docstrings 2) Fix some links Differential Revision: [D18588231](https://our.internmc.facebook.com/intern/diff/D18588231/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 20, 2019
Pull Request resolved: #30069 1) Fix rpc docstrings 2) Fix some links ghstack-source-id: 94250890 Differential Revision: [D18588231](https://our.internmc.facebook.com/intern/diff/D18588231/)
Contributor
|
This pull request has been merged in c06f902. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18588231