Design doc for Remote Reference #30066
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds design reasoning and walks through four scenarios for RRef. [ghstack-poisoned]
Contributor
Author
|
|
This commit adds design reasoning and walks through four scenarios for RRef. [ghstack-poisoned]
This commit adds design reasoning and walks through four scenarios for RRef. Differential Revision: [D18595094](https://our.internmc.facebook.com/intern/diff/D18595094) [ghstack-poisoned]
rohan-varma
reviewed
Nov 19, 2019
rohan-varma
reviewed
Nov 19, 2019
rohan-varma
reviewed
Nov 19, 2019
rohan-varma
reviewed
Nov 19, 2019
rohan-varma
reviewed
Nov 19, 2019
rohan-varma
reviewed
Nov 19, 2019
rohan-varma
reviewed
Nov 19, 2019
rohan-varma
reviewed
Nov 19, 2019
jlin27
approved these changes
Nov 19, 2019
rohan-varma
reviewed
Nov 19, 2019
rohan-varma
reviewed
Nov 19, 2019
rohan-varma
approved these changes
Nov 19, 2019
zhaojuanmao
reviewed
Nov 20, 2019
Contributor
zhaojuanmao
left a comment
zhaojuanmao
left a comment
There was a problem hiding this comment.
do you want to add some explanation for create RREF to itself, it will return an owner rref? also RREF(t) API ?
This commit adds design reasoning and walks through four scenarios for RRef. Differential Revision: [D18595094](https://our.internmc.facebook.com/intern/diff/D18595094) [ghstack-poisoned]
This commit adds design reasoning and walks through four scenarios for RRef. Differential Revision: [D18595094](https://our.internmc.facebook.com/intern/diff/D18595094) [ghstack-poisoned]
This commit adds design reasoning and walks through four scenarios for RRef. Differential Revision: [D18595094](https://our.internmc.facebook.com/intern/diff/D18595094) [ghstack-poisoned]
Contributor
Author
Will do this in followup PRs |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This commit adds design reasoning and walks through four scenarios
for RRef.
Differential Revision: D18595094