DistributedOptimizer: wait for all workers to finish _LocalOptimizer constructor #30062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…constructor This allows to catch exceptions during optimizer creation. Differential Revision: [D18586108](https://our.internmc.facebook.com/intern/diff/D18586108/) [ghstack-poisoned]
aazzolini
requested review from
apaszke,
mrshenli and
pietern
as code owners
aazzolini
added a commit
that referenced
this pull request
Nov 19, 2019
…constructor This allows to catch exceptions during optimizer creation. Differential Revision: [D18586108](https://our.internmc.facebook.com/intern/diff/D18586108/) ghstack-source-id: 94167914 Pull Request resolved: #30062
…lOptimizer constructor" This allows to catch exceptions during optimizer creation. Differential Revision: [D18586108](https://our.internmc.facebook.com/intern/diff/D18586108/) [ghstack-poisoned]
aazzolini
added a commit
that referenced
this pull request
Nov 19, 2019
…constructor Pull Request resolved: #30062 This allows to catch exceptions during optimizer creation. ghstack-source-id: 94173294 Differential Revision: [D18586108](https://our.internmc.facebook.com/intern/diff/D18586108/)
mrshenli
reviewed
Nov 19, 2019
torch/distributed/optim/optimizer.py
Outdated
| remote_optim_futs = [] | ||
| for worker, param_rrefs in per_worker_params_rref.items(): | ||
| remote_optim_rref = rpc.remote( | ||
| remote_optim_rref = rpc.rpc_async( |
Contributor
There was a problem hiding this comment.
this is actually a future, shall we rename this var?
…lOptimizer constructor" This allows to catch exceptions during optimizer creation. Differential Revision: [D18586108](https://our.internmc.facebook.com/intern/diff/D18586108/) [ghstack-poisoned]
aazzolini
added a commit
that referenced
this pull request
Nov 19, 2019
…constructor Pull Request resolved: #30062 This allows to catch exceptions during optimizer creation. ghstack-source-id: 94232436 Differential Revision: [D18586108](https://our.internmc.facebook.com/intern/diff/D18586108/)
Contributor
|
This pull request has been merged in 07e14c7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This allows to catch exceptions during optimizer creation.
Differential Revision: D18586108