[iOS] add an unit test target to TestApp #29962
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xta0
changed the title
xta0
changed the title
xta0
added
the
module: ios
shoumikhin
reviewed
Nov 18, 2019
Contributor
shoumikhin
left a comment
shoumikhin
left a comment
There was a problem hiding this comment.
Did we run clang-format on it?
| } | ||
| torch::autograd::AutoGradMode guard(false); | ||
| _module = torch::jit::load(std::string(modelPath.UTF8String)); | ||
| _module.eval(); |
Contributor
There was a problem hiding this comment.
nit: maybe better to have it in each test, since some tests may actually want to change module's parameters in future?
Contributor
Author
There was a problem hiding this comment.
what parameters could be changed?
| @@ -0,0 +1,38 @@ | |||
| #import <XCTest/XCTest.h> | |||
| #import <torch/script.h> | |||
Contributor
There was a problem hiding this comment.
nit: #include C++ headers?
Also, may like an LF between the two, since they belong to different types of headers
| [super setUp]; | ||
| NSString* modelPath = [[NSBundle bundleForClass:[self class]] pathForResource:@"model" | ||
| ofType:@"pt"]; | ||
| XCTAssertTrue([[NSFileManager defaultManager] fileExistsAtPath:modelPath], |
Contributor
There was a problem hiding this comment.
nit: dot-syntax for the class property?
| at::globalContext().setQEngine(at::QEngine::QNNPACK); | ||
| } | ||
| torch::autograd::AutoGradMode guard(false); | ||
| _module = torch::jit::load(std::string(modelPath.UTF8String)); |
Contributor
There was a problem hiding this comment.
nit: probably no need to convert char* to std::string explicitly?
### Summary Recently we've found that the master branch was constantly broken due to some unwanted change being landed on mobile. The problem is that our CI was not able to detect the runtime errors. Starting from this PR, we'll add some unit tests to the iOS Simulator build. As follows: 1. Add an unit test target to XCode (this PR) 2. Use Fastlane to run the tests on CI 3. Modify the CI scripts to trigger tests ### Test Plan - Don't break the existing CI jobs unless they are flaky.
Contributor
Author
I did. |
Contributor
xta0
added a commit
that referenced
this pull request
Nov 22, 2019
### Summary Recently we've found that the master branch was constantly broken due to some unwanted change being landed on mobile. The problem is that our CI was not able to detect the runtime errors. ### Previous work - Add an unit test target to the iOS TestApp ( #29962 ) - Update Fastlane to run tests ( #29963 ) ### What's been changed in CI 1. XCode version has been updated to 11.2.1 2. For iOS simulator build, we'll run some unit tests( currently only one) after the build test. Differential Revision: [D18641413](https://our.internmc.facebook.com/intern/diff/D18641413)
xta0
added a commit
that referenced
this pull request
Nov 22, 2019
### Summary Recently we've found that the master branch was constantly broken due to some unwanted change being landed on mobile. The problem is that our CI was not able to detect the runtime errors. ### Previous work - Add an unit test target to the iOS TestApp ( #29962 ) - Update Fastlane to run tests ( #29963 ) ### What's been changed in CI 1. XCode version has been updated to 11.2.1 2. For iOS simulator build, we'll run some unit tests( currently only one) after the build test. Differential Revision: [D18641413](https://our.internmc.facebook.com/intern/diff/D18641413)
xta0
added a commit
that referenced
this pull request
Nov 22, 2019
### Summary Recently we've found that the master branch was constantly broken due to some unwanted change being landed on mobile. The problem is that our CI was not able to detect the runtime errors. ### Previous work - Add an unit test target to the iOS TestApp ( #29962 ) - Update Fastlane to run tests ( #29963 ) ### What's been changed in CI 1. XCode version has been updated to 11.2.1 2. For iOS simulator build, we'll run some unit tests( currently only one) after the build test. Differential Revision: [D18641413](https://our.internmc.facebook.com/intern/diff/D18641413)
xta0
added a commit
that referenced
this pull request
Nov 22, 2019
### Summary Recently we've found that the master branch was constantly broken due to some unwanted change being landed on mobile. The problem is that our CI was not able to detect the runtime errors. ### Previous work - Add an unit test target to the iOS TestApp ( #29962 ) - Update Fastlane to run tests ( #29963 ) ### What's been changed in CI 1. XCode version has been updated to 11.2.1 2. For iOS simulator build, we'll run some unit tests( currently only one) after the build test. Differential Revision: [D18641413](https://our.internmc.facebook.com/intern/diff/D18641413)
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 22, 2019
Summary: Pull Request resolved: #30133 ### Summary Recently we've found that the master branch was constantly broken due to some unwanted change being landed on mobile. The problem is that our CI was not able to detect the runtime errors. ### Previous work - Add an unit test target to the iOS TestApp ( #29962 ) - Update Fastlane to run tests ( #29963 ) ### What's been changed in CI 1. XCode version has been updated to 11.2.1 2. For iOS simulator build, we'll run some unit tests( currently only one) after the build test. Test Plan: Imported from OSS Differential Revision: D18641413 Pulled By: xta0 fbshipit-source-id: 12942206f1dee045b2addba3ae618760e992752c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary
Recently we've found that the master branch was constantly broken due to some unwanted change being landed on mobile. The problem is that our CI was not able to detect the runtime errors. Starting from this PR, we'll add some unit tests to the iOS Simulator build. As follows:
Test Plan
Differential Revision: D18582908