Add hash and equality operators for WorkerInfo #29958
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DistributedOptimizer relies on hashing WorkerInfo in order to coalesce fan-out RPCs. This will likely be a very common use case (EASGD will do the same, for example). Differential Revision: [D18548257](https://our.internmc.facebook.com/intern/diff/D18548257/) [ghstack-poisoned]
aazzolini
added a commit
that referenced
this pull request
Nov 16, 2019
DistributedOptimizer relies on hashing WorkerInfo in order to coalesce fan-out RPCs. This will likely be a very common use case (EASGD will do the same, for example). Differential Revision: [D18548257](https://our.internmc.facebook.com/intern/diff/D18548257/) ghstack-source-id: 94058908 Pull Request resolved: #29958
pritamdamania87
approved these changes
Nov 16, 2019
Contributor
pritamdamania87
left a comment
pritamdamania87
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
DistributedOptimizer relies on hashing WorkerInfo in order to coalesce fan-out RPCs. This will likely be a very common use case (EASGD will do the same, for example). Differential Revision: [D18548257](https://our.internmc.facebook.com/intern/diff/D18548257/) [ghstack-poisoned]
aazzolini
added a commit
that referenced
this pull request
Nov 18, 2019
Pull Request resolved: #29958 DistributedOptimizer relies on hashing WorkerInfo in order to coalesce fan-out RPCs. This will likely be a very common use case (EASGD will do the same, for example). ghstack-source-id: 94130564 Differential Revision: [D18548257](https://our.internmc.facebook.com/intern/diff/D18548257/)
DistributedOptimizer relies on hashing WorkerInfo in order to coalesce fan-out RPCs. This will likely be a very common use case (EASGD will do the same, for example). Differential Revision: [D18548257](https://our.internmc.facebook.com/intern/diff/D18548257/) [ghstack-poisoned]
aazzolini
added a commit
that referenced
this pull request
Nov 19, 2019
Pull Request resolved: #29958 DistributedOptimizer relies on hashing WorkerInfo in order to coalesce fan-out RPCs. This will likely be a very common use case (EASGD will do the same, for example). ghstack-source-id: 94169198 Differential Revision: [D18548257](https://our.internmc.facebook.com/intern/diff/D18548257/)
Contributor
|
This pull request has been merged in 97156f5. |
1 similar comment
Contributor
|
This pull request has been merged in 97156f5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
DistributedOptimizer relies on hashing WorkerInfo in order to coalesce fan-out RPCs. This will likely be a very common use case (EASGD will do the same, for example).
Differential Revision: D18548257