Polish distributed autograd docs. #29942
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Added links to the design. 2) Fixed function signautres. 3) Expanded examples Differential Revision: [D18547103](https://our.internmc.facebook.com/intern/diff/D18547103/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 16, 2019
1) Added links to the design. 2) Fixed function signautres. 3) Expanded examples Differential Revision: [D18547103](https://our.internmc.facebook.com/intern/diff/D18547103/) ghstack-source-id: 94054593 Pull Request resolved: #29942
rohan-varma
reviewed
Nov 18, 2019
docs/source/rpc.rst
Outdated
| may send and receive gradient recording tensors over RPC. In the forward pass, | ||
| we record when gradient recording tensors are sent over RPC and during the | ||
| backward pass we use this information to perform a distributed backward pass | ||
| using RPC. For more details see the design doc |
Contributor
There was a problem hiding this comment.
You may want to rebase to avoid merge conflicts as this is different in the latest master (it was updated to refer to the note when that PR got merged)
rohan-varma
approved these changes
Nov 18, 2019
Contributor
rohan-varma
left a comment
rohan-varma
left a comment
There was a problem hiding this comment.
Thanks for improving our documentation!
1) Added links to the design. 2) Fixed function signautres. 3) Expanded examples Differential Revision: [D18547103](https://our.internmc.facebook.com/intern/diff/D18547103/) [ghstack-poisoned]
pritamdamania87
pushed a commit
that referenced
this pull request
Nov 19, 2019
Pull Request resolved: #29942 1) Added links to the design. 2) Fixed function signautres. 3) Expanded examples ghstack-source-id: 94162372 Differential Revision: [D18547103](https://our.internmc.facebook.com/intern/diff/D18547103/)
Contributor
|
This pull request has been merged in ab93b3d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D18547103