Skip to content

[C++ API] torch::nn::GLU and F::glu #29922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yf225 wants to merge 5 commits into from
Closed

[C++ API] torch::nn::GLU and F::glu #29922

yf225 wants to merge 5 commits into from

Conversation

@yf225
Copy link
Contributor

@yf225 yf225 commented Nov 15, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D18558818

@yf225 yf225 mentioned this pull request Nov 15, 2019
Closed
Update on "[C++ API] torch::nn::GLU and F::glu"
ee98867 
[C++ API] torch::nn::GLU and F::glu

gh-metadata: pytorch pytorch 29922 gh/yf225/76/head
Update on "[C++ API] torch::nn::GLU and F::glu"
0e369bd 
[C++ API] torch::nn::GLU and F::glu

gh-metadata: pytorch pytorch 29922 gh/yf225/76/head
@yf225 yf225 requested a review from pbelevich November 15, 2019 21:54
@yf225 yf225 mentioned this pull request Nov 15, 2019
Closed
Update on "[C++ API] torch::nn::GLU and F::glu"
6cc31ac 
[C++ API] torch::nn::GLU and F::glu

gh-metadata: pytorch pytorch 29922 gh/yf225/76/head
@kostmo
Copy link
Member

kostmo commented Nov 16, 2019

CircleCI build failures summary

As of commit 6cc31ac:

  • 1/1 failures introduced in this PR
  • 0/1 recognized as flaky

Here are the reasons each build failed:

Job Step Log excerpt
pytorch_linux_xenial_py3_clang5_asan_test Test RuntimeError: test_jit failed!

This comment was automatically generated by Dr. CI.
Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

Update on "[C++ API] torch::nn::GLU and F::glu"
d57758f 
[C++ API] torch::nn::GLU and F::glu

gh-metadata: pytorch pytorch 29922 gh/yf225/76/head
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 17, 2019

@yf225 merged this pull request in 689b4be.

@yf225 yf225 mentioned this pull request Nov 19, 2019
Open
@yf225 yf225 added the module: cpp Related to C++ API label Nov 19, 2019
@facebook-github-bot facebook-github-bot deleted the gh/yf225/76/head branch November 20, 2019 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pbelevich pbelevich pbelevich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged module: cpp Related to C++ API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yf225 @kostmo @facebook-github-bot @pbelevich @mruberry