Skip to content

Represent the original python name the same way in traced and scripted modules. #29912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ZolotukhinM wants to merge 3 commits into from
Closed

Represent the original python name the same way in traced and scripted modules. #29912

ZolotukhinM wants to merge 3 commits into from

Conversation

@ZolotukhinM
Copy link

@ZolotukhinM ZolotukhinM commented Nov 15, 2019 •
edited
Loading

Stack from ghstack:

Differential Revision: D18533135

@ZolotukhinM ZolotukhinM requested a review from apaszke as a code owner November 15, 2019 18:35
ZolotukhinM pushed a commit that referenced this pull request Nov 15, 2019
Represent the original python name the same way in traced and scripte…
29aba88 
…d modules.

ghstack-source-id: 74bf0e4
Pull Request resolved: #29912
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Nov 15, 2019
jamesr66a
jamesr66a approved these changes Nov 20, 2019
View reviewed changes
Copy link
Collaborator

@jamesr66a jamesr66a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

ZolotukhinM pushed a commit that referenced this pull request Nov 20, 2019
Represent the original python name the same way in traced and scripte…
ed20a98 
…d modules.

ghstack-source-id: 5651c4e
Pull Request resolved: #29912
ZolotukhinM pushed a commit that referenced this pull request Nov 21, 2019
Represent the original python name the same way in traced and scripte…
71b1ef5 
…d modules.

ghstack-source-id: 3502a25
Pull Request resolved: #29912
@facebook-github-bot facebook-github-bot deleted the gh/ZolotukhinM/146/head branch December 10, 2019 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesr66a jamesr66a jamesr66a approved these changes

@apaszke apaszke Awaiting requested review from apaszke

@suo suo Awaiting requested review from suo

@driazati driazati Awaiting requested review from driazati

Assignees

No one assigned

Labels

oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZolotukhinM @jamesr66a @facebook-github-bot